Commit 84b98c7

authored

Merge pull request #193 from tttapa/patch-2

Fix stack buffer overflow in String::getBytes() test

2 parents 5b9faf6 + 363c2c4 commit 84b98c7Copy full SHA for 84b98c7

File tree

-3

lines changed

-3

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -121,8 +121,8 @@ add_compile_definitions(HOST)`
`121`	`121`	`add_compile_options(-Wall -Wextra -Wpedantic -Werror)`
`122`	`122`	`add_compile_options(-Wno-cast-function-type)`
`123`	`123`
`124`		`-set(CMAKE_C_FLAGS ${CMAKE_C_FLAGS} "--coverage")`
`125`		`-set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} "--coverage -Wno-deprecated-copy")`
	`124`	`+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} --coverage")`
	`125`	`+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --coverage -Wno-deprecated-copy")`
`126`	`126`
`127`	`127`	`##########################################################################`
`128`	`128`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -45,10 +45,11 @@ TEST_CASE ("Testing String::getBytes(unsigned char, unsigned int, unsigned int)"`
`45`	`45`
`46`	`46`	`WHEN("Valid operation") {`
`47`	`47`	`arduino::String str("Hello");`
`48`		`- unsigned char buf[2];`
	`48`	`+ unsigned char buf[3];`
`49`	`49`	`str.getBytes(buf, 5, 3);`
`50`	`50`	`REQUIRE(buf[0] == 'l');`
`51`	`51`	`REQUIRE(buf[1] == 'o');`
	`52`	`+ REQUIRE(buf[2] == '0円');`
`52`	`53`	`}`
`53`	`54`	`}`
`54`	`55`

Comments

(0)