-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Git integration inside the IDE (commit only) #4865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just for reference, relating this other PR here: #4816
990bba4
to
68d5a2e
Compare
Added ability to perform diff and reset.
Added GUI for Diff
wow, three pull request for git integration in three weeks. It seems that there is a very compelling need to add Git to the Arduino IDE
@carlosperate @baydindima
I see that you, both, added more features than the original poster asked in arduino/arduino-ide#1880. Probably you felt the need to have something more than just a "Commit" command, but even now that those "extra" features are there, they are poorly implemented and leaves a lot to desire. BTW I'm not listing here what works and what not, this is not the purpose of this message and I don't want to do GUI design considerations here, what I want to know from you guys, is if you are willing to invest time to work seriously on this feature. As I already said a proper Git integration (even only the basic commands) is a project on his own.
If the answer is yes, you should probably start the git integration as an Arduino IDE Tool Plugin, in his own repository so people can start to tinker with it and give feedbacks. Here some examples:
https://github.com/esp8266/arduino-esp8266fs-plugin
https://github.com/me-no-dev/EspExceptionDecoder
https://github.com/sandeepmistry/arduino-nRF5/tree/master/extras/ide-tools
Moreover I'd like to see you cooperate instead of competing each other, developers time is a scarce resource!
@cmaglie, I think you meant @CarlosMiguelCuevas, posting here so that he can get the notification as well.
oh yes thanks! sorry for the confusion
fededim
commented
Jun 29, 2017
Any plan solve the conflicts and to merge this PR ?
silbo
commented
Apr 10, 2019
Awesome stuff, would be epic to see it in production.
This work just stopped ? Anyone working on merging it ?
CarlosMiguelCuevas
commented
Apr 12, 2019
@cmaglie I won't be able to continue working on this, actually, I just closed my PR (if someone is interested in the code, the branch was not deleted so the code is there). I didn't check @baydindima 's code but it seems he went furder. so make it happen and good luck.
Uh oh!
There was an error while loading. Please reload this page.
Сompletely rewrote the code #4704. Now I am using library for work with Git. Now you can init new repository, commit and log commits. This is solve the issue arduino/arduino-ide#1880.
@cmaglie please review and comment my solution.