Commit fa4876b

committed

Fixed unit-test UploaderFactoryTest

It was broken after merging #4107

1 parent 376cb56 commit fa4876bCopy full SHA for fa4876b

File tree

1 file changed

+22

-5

lines changed

app/test/processing/app/debug
- UploaderFactoryTest.java

1 file changed

+22

-5

lines changed

`‎app/test/processing/app/debug/UploaderFactoryTest.java‎`

Lines changed: 22 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -29,19 +29,21 @@`
`29`	`29`
`30`	`30`	`package processing.app.debug;`
`31`	`31`
	`32`	`+import static org.junit.Assert.assertTrue;`
	`33`	`+`
	`34`	`+import java.util.HashMap;`
	`35`	`+`
	`36`	`+import org.junit.Test;`
	`37`	`+`
`32`	`38`	`import cc.arduino.packages.BoardPort;`
`33`	`39`	`import cc.arduino.packages.Uploader;`
`34`	`40`	`import cc.arduino.packages.UploaderFactory;`
	`41`	`+import cc.arduino.packages.uploaders.GenericNetworkUploader;`
`35`	`42`	`import cc.arduino.packages.uploaders.SSHUploader;`
`36`	`43`	`import cc.arduino.packages.uploaders.SerialUploader;`
`37`		`-import org.junit.Test;`
`38`	`44`	`import processing.app.AbstractWithPreferencesTest;`
`39`	`45`	`import processing.app.helpers.PreferencesMap;`
`40`	`46`
`41`		`-import java.util.HashMap;`
`42`		`-`
`43`		`-import static org.junit.Assert.assertTrue;`
`44`		`-`
`45`	`47`	`public class UploaderFactoryTest extends AbstractWithPreferencesTest {`
`46`	`48`
`47`	`49`	`@Test`
`@@ -52,11 +54,26 @@ public void shouldCreateAnInstanceOfSSHUploader() throws Exception {`
`52`	`54`	`boardPort.setBoardName("yun");`
`53`	`55`	`boardPort.setAddress("192.168.0.1");`
`54`	`56`	`boardPort.setProtocol("network");`
	`57`	`+ boardPort.getPrefs().put("ssh_upload", "yes");`
`55`	`58`	`Uploader uploader = new UploaderFactory().newUploader(board, boardPort, false);`
`56`	`59`
`57`	`60`	`assertTrue(uploader instanceof SSHUploader);`
`58`	`61`	`}`
`59`	`62`
	`63`	`+ @Test`
	`64`	`+ public void shouldCreateAnInstanceOfGenericNetworkUploader() throws Exception {`
	`65`	`+ TargetBoard board = new LegacyTargetBoard("yun", new PreferencesMap(new HashMap<String, String>()), new TargetPlatformStub("id", new TargetPackageStub("id")));`
	`66`	`+`
	`67`	`+ BoardPort boardPort = new BoardPort();`
	`68`	`+ boardPort.setBoardName("yun");`
	`69`	`+ boardPort.setAddress("192.168.0.1");`
	`70`	`+ boardPort.setProtocol("network");`
	`71`	`+ boardPort.getPrefs().put("ssh_upload", "no");`
	`72`	`+ Uploader uploader = new UploaderFactory().newUploader(board, boardPort, false);`
	`73`	`+`
	`74`	`+ assertTrue(uploader instanceof GenericNetworkUploader);`
	`75`	`+ }`
	`76`	`+`
`60`	`77`	`@Test`
`61`	`78`	`public void shouldCreateAnInstanceOfBasicUploaderWhenPortIsSerial() throws Exception {`
`62`	`79`	`TargetBoard board = new LegacyTargetBoard("uno", new PreferencesMap(new HashMap<String, String>()), new TargetPlatformStub("id", new TargetPackageStub("id")));`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit fa4876b

File tree

1 file changed

1 file changed

`‎app/test/processing/app/debug/UploaderFactoryTest.java‎`

0 commit comments