Commit 328296a

facchinmcmaglie

authored and

committed

Only reapply serial monitor last location if it fits the screen

There could be a couple of edge cases in this approach (for example, if someone wants to keep the serial monitor window only half visible). However, it should be at least safe (no serial monitors on the second screen) if the Window Manager acts correctly (by moving all the windows on the second monitor to the primary on detach).

1 parent 8292989 commit 328296aCopy full SHA for 328296a

File tree

1 file changed

-11

lines changed

app/src/processing/app
- AbstractMonitor.java

1 file changed

-11

lines changed

`‎app/src/processing/app/AbstractMonitor.java‎`

Lines changed: 5 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -59,17 +59,11 @@ public void actionPerformed(ActionEvent event) {`
`59`	`59`	`pack();`
`60`	`60`
`61`	`61`	`Dimension screen = Toolkit.getDefaultToolkit().getScreenSize();`
`62`		`- if (PreferencesData.get("last.screen.height") != null) {`
`63`		`- // if screen size has changed, the window coordinates no longer`
`64`		`- // make sense, so don't use them unless they're identical`
`65`		`- int screenW = PreferencesData.getInteger("last.screen.width");`
`66`		`- int screenH = PreferencesData.getInteger("last.screen.height");`
`67`		`- if ((screen.width == screenW) && (screen.height == screenH)) {`
`68`		`- String locationStr = PreferencesData.get("last.serial.location");`
`69`		`- if (locationStr != null) {`
`70`		`- int[] location = PApplet.parseInt(PApplet.split(locationStr, ','));`
`71`		`- setPlacement(location);`
`72`		`- }`
	`62`	`+ String locationStr = PreferencesData.get("last.serial.location");`
	`63`	`+ if (locationStr != null) {`
	`64`	`+ int[] location = PApplet.parseInt(PApplet.split(locationStr, ','));`
	`65`	`+ if (location[0] + location[2] <= screen.width && location[1] + location[3] <= screen.height) {`
	`66`	`+ setPlacement(location);`
`73`	`67`	`}`
`74`	`68`	`}`
`75`	`69`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 328296a

File tree

1 file changed

1 file changed

`‎app/src/processing/app/AbstractMonitor.java‎`

0 commit comments