Commit 4e5dccd

author

RobVS

committed

PDU rejected due to wrong opcode set in 'Request Opcode In Error'

3.4.1.1 of ATT protocol spec suggests that in the ATT_ERROR_RSP, the Request Opcode In Error should be set to the request that generated the error. In this case it looks like it should actually be ATT_FIND_BY_TYPE_VALUE_REQ (ATT_OP_READ_BY_GROUP_REQ)

1 parent 1768462 commit 4e5dccdCopy full SHA for 4e5dccd

File tree

1 file changed

-2

lines changed

src/utility
- ATT.cpp

1 file changed

-2

lines changed

`‎src/utility/ATT.cpp`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -756,7 +756,7 @@ void ATTClass::findByTypeReq(uint16_t connectionHandle, uint16_t mtu, uint8_t dl`
`756`	`756`	`} findByTypeReq = (FindByTypeReq)data;`
`757`	`757`
`758`	`758`	`if (dlen < sizeof(FindByTypeReq)) {`
`759`		`- sendError(connectionHandle, ATT_OP_FIND_BY_TYPE_RESP, findByTypeReq->startHandle, ATT_ECODE_INVALID_PDU);`
	`759`	`+ sendError(connectionHandle, ATT_OP_FIND_BY_TYPE_REQ, findByTypeReq->startHandle, ATT_ECODE_INVALID_PDU);`
`760`	`760`	`return;`
`761`	`761`	`}`
`762`	`762`
`@@ -794,7 +794,7 @@ void ATTClass::findByTypeReq(uint16_t connectionHandle, uint16_t mtu, uint8_t dl`
`794`	`794`	`}`
`795`	`795`
`796`	`796`	`if (responseLength == 1) {`
`797`		`- sendError(connectionHandle, ATT_OP_FIND_BY_TYPE_RESP, findByTypeReq->startHandle, ATT_ECODE_ATTR_NOT_FOUND);`
	`797`	`+ sendError(connectionHandle, ATT_OP_FIND_BY_TYPE_REQ, findByTypeReq->startHandle, ATT_ECODE_ATTR_NOT_FOUND);`
`798`	`798`	`} else {`
`799`	`799`	`HCI.sendAclPkt(connectionHandle, ATT_CID, responseLength, response);`
`800`	`800`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 4e5dccd

File tree

1 file changed

1 file changed

`‎src/utility/ATT.cpp`

0 commit comments