Commit 0b9e84a

committed

[WIP] Add comments and print for revisions

1 parent 89fd740 commit 0b9e84aCopy full SHA for 0b9e84a

File tree

-0

lines changed

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,10 @@ int BLELocalCharacteristic::writeValue(const uint8_t value[], int length)`
`123`	`123`
`124`	`124`	`GAP.setAdvertisedServiceData(serviceUuid, value, length);`
`125`	`125`
	`126`	`+ // TO BE REVISIONED`
	`127`	`+ // could advertise also if connected`
`126`	`128`	`if (!ATT.connected() && GAP.advertising()) {`
	`129`	`+ // if it is already advertising it should stop before requesting advertising again`
`127`	`130`	`GAP.advertise();`
`128`	`131`	`}`
`129`	`132`	`}`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -620,6 +620,10 @@ void HCIClass::handleEventPkt(uint8_t /plen/, uint8_t pdata[])`
`620`	`620`	`uint16_t supervisionTimeout;`
`621`	`621`	`uint8_t masterClockAccuracy;`
`622`	`622`	`} leConnectionComplete = (EvtLeConnectionComplete)&pdata[sizeof(HCIEventHdr) + sizeof(LeMetaEventHeader)];`
	`623`	`+`
	`624`	`+ // CLIENT: 0x01 / PERIPHERAL: 0x00`
	`625`	`+ Serial.println("role:");`
	`626`	`+ Serial.println(leConnectionComplete->role);`
`623`	`627`
`624`	`628`	`if (leConnectionComplete->status == 0x00) {`
`625`	`629`	`ATT.addConnection(leConnectionComplete->handle,`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -259,6 +259,8 @@ size_t HCICordioTransportClass::write(const uint8_t* data, size_t length)`
`259`	`259`	`void HCICordioTransportClass::handleRxData(uint8_t* data, uint8_t len)`
`260`	`260`	`{`
`261`	`261`	`if (_rxBuf.availableForStore() < len) {`
	`262`	`+ // This drop can cause many problems`
	`263`	`+ Serial.println("DROP");`
`262`	`264`	`// drop!`
`263`	`265`	`return;`
`264`	`266`	`}`

Comments

(0)