-
Notifications
You must be signed in to change notification settings - Fork 6
Why doesn’t SessionDataSet implement the IAsyncDisposable interface? #54
Open
Description
Currently, SessionDataSet implements the IDisposable interface. However, in its Dispose() method, the asynchronous Close() method is invoked synchronously.
Actual implementation:
protected virtual void Dispose(bool disposing) { if (this.disposedValue) return; if (disposing) { try { //synchronous call this.Close().Wait(); } catch { } } this.disposedValue = true; }
Proposed implementation:
protected virtual Task DisposeAsync(bool disposing) { if (this.disposedValue) return; if (disposing) { try { //asynchronous call await this.Close(); } catch { } } this.disposedValue = true; }
Activity
Metadata
Metadata
Assignees
Labels
No labels