-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Semantics of FileMetaDataBuilder::Finish() and saving memory by moving std::vector<RowGroup> metadata #47676
Answered
by
raulcd
kostrzewa9ld
asked this question in
Q&A
I've noticed that in FileMetaDataBuilderImpl::Finish() there is a copy of row_groups_ field done by passing it via const& to metadata_->__set_row_groups(row_groups_). However, if it is assumed that after calling the Finish() method nothing should be touching the row_groups_ field anymore then maybe it could be moved instead?
All reactions
Answered by
raulcd
Oct 3, 2025
In my opinion this makes sense, do you want to open an issue and submit a PR?
Replies: 1 comment 1 reply
In my opinion this makes sense, do you want to open an issue and submit a PR?
All reactions
1 reply
Sure, I will give it a try in a few days.
All reactions
Answer selected by
kostrzewa9ld
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment