-
Notifications
You must be signed in to change notification settings - Fork 0
vector serialization does not take into account endianness #53
Open
Description
The gRPC protocol is defined as sending over the bytes of arrays directly, but does not take into account endianness. This means the protocol will fail spectacularly (type 3 error, bad data with no error) if the client and server machines have different native endianness.
std::string ansys::grpc::client::GRPCClient::serialize_vector(
vector_as_chunk=arg[tmp_idx:last_idx_chunk].tobytes(),
Unless there is another reason, I recommend using gRPC arrays instead of bytes. gRPC can handle this for us.