Commit 64fc749

committed

apveyor, gitpython-developers#519: FIX incomplete Popen pump

+ Pump once, so when input larger than `mmap.PAGESIZE`, stream is not emptied.

1 parent d12fdca commit 64fc749Copy full SHA for 64fc749

File tree

-8

lines changed

-8

lines changed

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -100,16 +100,16 @@ def _parse_lines_from_buffer(buf):`
`100`	`100`	`# end`
`101`	`101`
`102`	`102`	`def _read_lines_from_fno(fno, last_buf_list):`
`103`		`- buf =os.read(fno, mmap.PAGESIZE)`
`104`		`- buf = last_buf_list[0] + buf`
	`103`	`+ forbuf initer(lambda: os.read(fno, mmap.PAGESIZE), b''):`
	`104`	`+ buf = last_buf_list[0] + buf`
`105`	`105`
`106`		`- bi = 0`
`107`		`- for bi, line in _parse_lines_from_buffer(buf):`
`108`		`- yield line`
`109`		`- # for each line to parse from the buffer`
	`106`	`+ bi = 0`
	`107`	`+ for bi, line in _parse_lines_from_buffer(buf):`
	`108`	`+ yield line`
	`109`	`+ # for each line to parse from the buffer`
`110`	`110`
`111`		`- # keep remainder`
`112`		`- last_buf_list[0] = buf[bi:]`
	`111`	`+ # keep remainder`
	`112`	`+ last_buf_list[0] = buf[bi:]`
`113`	`113`
`114`	`114`	`def _dispatch_single_line(line, handler):`
`115`	`115`	`line = line.decode(defenc)`

Comments

(0)