Commit 1b5f334

committed

refactor(cdk/overlay): remove unnecessary providers

Removes a couple of providers that aren't necessary anymore after the switch to standalone.

1 parent 124184a commit 1b5f334Copy full SHA for 1b5f334

File tree

2 files changed

-33

lines changed

src/cdk/overlay
- overlay-directives.ts
- overlay-module.ts

2 files changed

-33

lines changed

`‎src/cdk/overlay/overlay-directives.ts`

Lines changed: 1 addition & 27 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,11 +39,7 @@ import {`
`39`	`39`	`FlexibleConnectedPositionStrategy,`
`40`	`40`	`FlexibleConnectedPositionStrategyOrigin,`
`41`	`41`	`} from './position/flexible-connected-position-strategy';`
`42`		`-import {`
`43`		`- createRepositionScrollStrategy,`
`44`		`- RepositionScrollStrategy,`
`45`		`- ScrollStrategy,`
`46`		`-} from './scroll/index';`
	`42`	`+import {createRepositionScrollStrategy, ScrollStrategy} from './scroll/index';`
`47`	`43`
`48`	`44`	`/** Default set of positions for the overlay. Follows the behavior of a dropdown. */`
`49`	`45`	`const defaultPositionList: ConnectedPosition[] = [`
`@@ -462,25 +458,3 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {`
`462`	`458`	`this.open = false;`
`463`	`459`	`}`
`464`	`460`	`}`
`465`		`-`
`466`		`-/**`
`467`		`- * @docs-private`
`468`		`- * @deprecated No longer used, will be removed.`
`469`		`- * @breaking-change 21.0.0`
`470`		`- */`
`471`		`-export function CDK_CONNECTED_OVERLAY_SCROLL_STRATEGY_PROVIDER_FACTORY(`
`472`		`- overlay: unknown,`
`473`		`-): () => RepositionScrollStrategy {`
`474`		`- const injector = inject(Injector);`
`475`		`- return () => createRepositionScrollStrategy(injector);`
`476`		`-}`
`477`		`-`
`478`		`-/**`
`479`		`- * @docs-private`
`480`		`- * @deprecated No longer used, will be removed.`
`481`		`- * @breaking-change 21.0.0`
`482`		`- */`
`483`		`-export const CDK_CONNECTED_OVERLAY_SCROLL_STRATEGY_PROVIDER = {`
`484`		`- provide: CDK_CONNECTED_OVERLAY_SCROLL_STRATEGY,`
`485`		`- useFactory: CDK_CONNECTED_OVERLAY_SCROLL_STRATEGY_PROVIDER_FACTORY,`
`486`		`-};`

`‎src/cdk/overlay/overlay-module.ts`

Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,16 +11,12 @@ import {PortalModule} from '../portal';`
`11`	`11`	`import {ScrollingModule} from '../scrolling';`
`12`	`12`	`import {NgModule} from '@angular/core';`
`13`	`13`	`import {Overlay} from './overlay';`
`14`		`-import {`
`15`		`- CDK_CONNECTED_OVERLAY_SCROLL_STRATEGY_PROVIDER,`
`16`		`- CdkConnectedOverlay,`
`17`		`- CdkOverlayOrigin,`
`18`		`-} from './overlay-directives';`
	`14`	`+import {CdkConnectedOverlay, CdkOverlayOrigin} from './overlay-directives';`
`19`	`15`
`20`	`16`	`@NgModule({`
`21`	`17`	`imports: [BidiModule, PortalModule, ScrollingModule, CdkConnectedOverlay, CdkOverlayOrigin],`
`22`	`18`	`exports: [CdkConnectedOverlay, CdkOverlayOrigin, ScrollingModule],`
`23`		`- providers: [Overlay,CDK_CONNECTED_OVERLAY_SCROLL_STRATEGY_PROVIDER],`
	`19`	`+ providers: [Overlay],`
`24`	`20`	`})`
`25`	`21`	`export class OverlayModule {}`
`26`	`22`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 1b5f334

File tree

2 files changed

2 files changed

`‎src/cdk/overlay/overlay-directives.ts`

`‎src/cdk/overlay/overlay-module.ts`

0 commit comments