-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: angular/angularfire
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Could not load branches
Nothing to show
Loading
...
head repository: angular/angularfire
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: tdkehoe-patch-2
Could not load branches
Nothing to show
Loading
- 4 commits
- 2 files changed
- 2 contributors
Commits on Oct 14, 2022
-
Updating callable functions documentation
In `app.module.ts` I put in commented out lines anticipating AngularFire 7. When AngularFire 7 is available for callable functions we can easily update the documentation with a few clicks. I also put in two lines showing how to run your functions in the Firebase emulator. I clearly indicated how to comment out these lines to run your functions in the cloud. I made an HTML view to show how to handle user input. Also I added a second set of curly brackets to `{{ data$ | async }}`. This is necessary to make the code run without throwing errors. In `app.component.ts` I put in lines anticipating AngularFire 7. I moved the template to an HTML view. I added a variable `data$` to handle the data returned from the cloud function. I added `this` to `fns.httpsCallable('my-fn-name');`. These changes are necessary to make the code run without throwing errors. I changed `fns` to `functions` for readability. I made two functions, one that executes on page load and the user executes on user input. I put in the `index.js` file showing the cloud functions. The old documentation was confusing as to what data went from Angular to the cloud function and what data was returned from the cloud function. Showing the `index.js` functions clarifies this. I've written a longer tutorial at https://github.com/tdkehoe/Firebase-Cloud-Functions-with-Angular/blob/main/README.md. When can we expect to use AngularFire 7 with callable functions?
Commits on Jun 23, 2023
-
Merge branch 'patch-2' of https://github.com/tdkehoe/angularfire into...
... tdkehoe-patch-2
davideast committedJun 23, 2023 -
Merge branch 'master' of https://github.com/angular/angularfire into ...
...tdkehoe-patch-2
davideast committedJun 23, 2023 -
davideast committed
Jun 23, 2023
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...tdkehoe-patch-2