Commit b4c3da8

authored

Quick fixes (#3362)

* Fix semver check for ng-deploy * Drop file-loader, fixes #3324

1 parent 7a2402a commit b4c3da8Copy full SHA for b4c3da8

File tree

-7

lines changed

-7

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ jobs:`
`108`	`108`	`if: steps.node_modules_cache.outputs.cache-hit != 'true'`
`109`	`109`	`run: yarn install --frozen-lockfile --prefer-offline`
`110`	`110`	`- name: Download Artifacts`
`111`		`- uses: actions/download-artifact@v2`
	`111`	`+ uses: actions/download-artifact@v3`
`112`	`112`	`- name: Relocate Artifacts`
`113`	`113`	`run: mv angularfire-${{ github.run_id }} dist`
`114`	`114`	`- name: Test Node`
`@@ -180,7 +180,7 @@ jobs:`
`180`	`180`	`path: ~/.cache/firebase/emulators`
`181`	`181`	`key: firebase_emulators`
`182`	`182`	`- name: Download Artifacts`
`183`		`- uses: actions/download-artifact@v2`
	`183`	`+ uses: actions/download-artifact@v3`
`184`	`184`	`- name: Relocate Artifacts`
`185`	`185`	`run: mv angularfire-${{ github.run_id }} dist`
`186`	`186`	`- name: Test browser`
`@@ -272,7 +272,7 @@ jobs:`
`272`	`272`	`registry-url: 'https://registry.npmjs.org'`
`273`	`273`	`check-latest: true`
`274`	`274`	`- name: 'Download Artifacts'`
`275`		`- uses: actions/download-artifact@v2`
	`275`	`+ uses: actions/download-artifact@v3`
`276`	`276`	`- name: Publish`
`277`	`277`	`run: \|`
`278`	`278`	`cd ./angularfire-${{ github.run_id }}/packages-dist`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -49,8 +49,7 @@`
`49`	`49`	`"node-fetch": "^2.6.1",`
`50`	`50`	`"semver": "^7.1.3",`
`51`	`51`	`"inquirer": "^8.1.1",`
`52`		`- "fs-extra": "^8.0.1",`
`53`		`- "file-loader": "^6.2.0"`
	`52`	`+ "fs-extra": "^8.0.1"`
`54`	`53`	`},`
`55`	`54`	`"ngPackage": {`
`56`	`55`	`"lib": {`
`@@ -69,7 +68,7 @@`
`69`	`68`	`"fuzzy", "inquirer-autocomplete-prompt",`
`70`	`69`	`"open", "jsonc-parser", "ora", "winston",`
`71`	`70`	`"triple-beam", "@schematics/angular", "node-fetch",`
`72`		`- "semver", "inquirer", "fs-extra","file-loader",`
	`71`	`+ "semver", "inquirer", "fs-extra",`
`73`	`72`	`"firebase", "rxfire"`
`74`	`73`	`]`
`75`	`74`	`},`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -397,7 +397,7 @@ export default async function deploy(`
`397`	`397`	`}`
`398`	`398`
`399`	`399`	`if (options.version && options.version >= 2) {`
`400`		`- if (lt(firebaseTools.cli.version(), '12.2')) {`
	`400`	`+ if (lt(firebaseTools.cli.version(), '12.2.0')) {`
`401`	`401`	`throw new SchematicsException('firebase-tools version 12.2+ is required.');`
`402`	`402`	`}`
`403`	`403`	`process.env.FIREBASE_FRAMEWORK_BUILD_TARGET = (prerenderBuildTarget \|\| serverBuildTarget \|\| staticBuildTarget).name;`

Comments

(0)