Commit e5aed6d

committed

fix(@angular/cli): show planned actions in ng add dry run

This commit improves the `--dry-run` functionality for the `ng add` command to provide a clearer summary of the actions that would be taken. Previously, the dry run output was minimal. Now, it explicitly states which package version would have been installed and confirms that the package's schematic would have been executed, without performing the actual installation. The installation confirmation prompt is also now skipped during a dry run.

1 parent 0d53e82 commit e5aed6dCopy full SHA for e5aed6d

File tree

1 file changed

+19

-1

lines changed

packages/angular/cli/src/commands/add
- cli.ts

1 file changed

+19

-1

lines changed

`‎packages/angular/cli/src/commands/add/cli.ts‎`

Lines changed: 19 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ interface AddCommandTaskContext {`
`50`	`50`	`collectionName?: string;`
`51`	`51`	`executeSchematic: AddCommandModule['executeSchematic'];`
`52`	`52`	`getPeerDependencyConflicts: AddCommandModule['getPeerDependencyConflicts'];`
	`53`	`+ dryRun?: boolean;`
`53`	`54`	`}`
`54`	`55`
`55`	`56`	`type AddCommandTaskWrapper = ListrTaskWrapper<`
`@@ -161,6 +162,7 @@ export default class AddCommandModule`
`161`	`162`	`packageIdentifier,`
`162`	`163`	`executeSchematic: this.executeSchematic.bind(this),`
`163`	`164`	`getPeerDependencyConflicts: this.getPeerDependencyConflicts.bind(this),`
	`165`	`+ dryRun: options.dryRun,`
`164`	`166`	`};`
`165`	`167`
`166`	`168`	`const tasks = new Listr<AddCommandTaskContext>(`
`@@ -183,11 +185,21 @@ export default class AddCommandModule`
`183`	`185`	`},`
`184`	`186`	`{`
`185`	`187`	`title: 'Confirming installation',`
`186`		`- enabled: !skipConfirmation,`
	`188`	`+ enabled: !skipConfirmation&&!options.dryRun,`
`187`	`189`	`task: (context, task) => this.confirmInstallationTask(context, task),`
`188`	`190`	`rendererOptions: { persistentOutput: true },`
`189`	`191`	`},`
`190`	`192`	`{`
	`193`	`+ title: 'Installing package',`
	`194`	`+ skip: (context) => {`
	`195`	`+ if (context.dryRun) {`
	`196`	+ return `Skipping package installation. Would install package ${color.blue(
	`197`	`+ context.packageIdentifier.toString(),`
	`198`	+ )}.`;
	`199`	`+ }`
	`200`	`+`
	`201`	`+ return false;`
	`202`	`+ },`
`191`	`203`	`task: (context, task) => this.installPackageTask(context, task, options),`
`192`	`204`	`rendererOptions: { bottomBar: Infinity },`
`193`	`205`	`},`
`@@ -202,6 +214,12 @@ export default class AddCommandModule`
`202`	`214`	`const result = await tasks.run(taskContext);`
`203`	`215`	`assert(result.collectionName, 'Collection name should always be available');`
`204`	`216`
	`217`	`+ if (options.dryRun) {`
	`218`	`+ logger.info('The package schematic would be executed next.');`
	`219`	`+`
	`220`	`+ return;`
	`221`	`+ }`
	`222`	`+`
`205`	`223`	`return this.executeSchematic({ ...options, collection: result.collectionName });`
`206`	`224`	`} catch (e) {`
`207`	`225`	`if (e instanceof CommandError) {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit e5aed6d

File tree

1 file changed

1 file changed

`‎packages/angular/cli/src/commands/add/cli.ts‎`

0 commit comments