Commit ddeb2b2

clydinalan-agius4

authored and

committed

fix(@angular-devkit/build-angular): remove outdated browser-esbuild option warning

The `resourcesOutputPath` option from the browser builder is supported as of 18.2. The unsupported warning is now removed. The warning logic has also been consolidated now that there are only several warnings left. (cherry picked from commit 0b161bc)

1 parent 0be4038 commit ddeb2b2Copy full SHA for ddeb2b2

File tree

2 files changed

+17

-54

lines changed

packages/angular_devkit/build_angular/src/builders/browser-esbuild
- builder-status-warnings.ts
- index.ts

2 files changed

+17

-54

lines changed

`‎packages/angular_devkit/build_angular/src/builders/browser-esbuild/builder-status-warnings.ts‎`

Lines changed: 0 additions & 51 deletions

This file was deleted.

`‎packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts‎`

Lines changed: 17 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@`
`9`	`9`	`import { type ApplicationBuilderOptions, buildApplication } from '@angular/build';`
`10`	`10`	`import { BuilderContext, BuilderOutput, createBuilder } from '@angular-devkit/architect';`
`11`	`11`	`import type { Plugin } from 'esbuild';`
`12`		`-import { logBuilderStatusWarnings } from './builder-status-warnings';`
`13`	`12`	`import type { Schema as BrowserBuilderOptions } from './schema';`
`14`	`13`
`15`	`14`	`export type { BrowserBuilderOptions };`
`@@ -31,10 +30,25 @@ export async function* buildEsbuildBrowser(`
`31`	`30`	`},`
`32`	`31`	`plugins?: Plugin[],`
`33`	`32`	`): AsyncIterable<BuilderOutput> {`
`34`		`- // Inform user of status of builder and options`
`35`		`- logBuilderStatusWarnings(userOptions, context);`
	`33`	`+ // Warn about any unsupported options`
	`34`	`+ if (userOptions['vendorChunk']) {`
	`35`	`+ context.logger.warn(`
	`36`	+ `The 'vendorChunk' option is not used by this builder and will be ignored.`,
	`37`	`+ );`
	`38`	`+ }`
	`39`	`+ if (userOptions['commonChunk'] === false) {`
	`40`	`+ context.logger.warn(`
	`41`	+ `The 'commonChunk' option is always enabled by this builder and will be ignored.`,
	`42`	`+ );`
	`43`	`+ }`
	`44`	`+ if (userOptions['webWorkerTsConfig']) {`
	`45`	+ context.logger.warn(`The 'webWorkerTsConfig' option is not yet supported by this builder.`);
	`46`	`+ }`
`36`	`47`
	`48`	`+ // Convert browser builder options to application builder options`
`37`	`49`	`const normalizedOptions = convertBrowserOptions(userOptions);`
	`50`	`+`
	`51`	`+ // Execute the application builder`
`38`	`52`	`yield* buildApplication(normalizedOptions, context, { codePlugins: plugins });`
`39`	`53`	`}`
`40`	`54`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit ddeb2b2

File tree

2 files changed

2 files changed

`‎packages/angular_devkit/build_angular/src/builders/browser-esbuild/builder-status-warnings.ts‎`

`‎packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts‎`

0 commit comments