Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit ca1e86b

Browse files
josephperrottclydin
authored andcommitted
build: disable failing strict_deps targets
Disable all failing strict_deps targets with TODOs to fix them moving forward.
1 parent 68ef24d commit ca1e86b

File tree

11 files changed

+63
-4
lines changed

11 files changed

+63
-4
lines changed

‎packages/angular/build/BUILD.bazel‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ ts_project(
7272
"//packages/angular/build:src/builders/ng-packagr/schema.ts",
7373
],
7474
data = RUNTIME_ASSETS,
75+
# TODO: Fix strict_deps failure
76+
ignore_strict_deps = True,
7577
module_name = "@angular/build",
7678
deps = [
7779
":node_modules/@angular-devkit/architect",
@@ -135,6 +137,8 @@ ts_project(
135137
include = ["src/**/*_spec.ts"],
136138
exclude = ["src/builders/**/tests/**"],
137139
),
140+
# TODO: Fix strict_deps failure
141+
ignore_strict_deps = True,
138142
deps = [
139143
":build_rjs",
140144
"//:node_modules/@angular/compiler-cli",
@@ -155,6 +159,8 @@ ts_project(
155159
name = "application_integration_test_lib",
156160
testonly = True,
157161
srcs = glob(include = ["src/builders/application/tests/**/*.ts"]),
162+
# TODO: Fix strict_deps failure
163+
ignore_strict_deps = True,
158164
deps = [
159165
":build_rjs",
160166
"//packages/angular/build/private:private_rjs",
@@ -181,6 +187,8 @@ ts_project(
181187
name = "dev-server_integration_test_lib",
182188
testonly = True,
183189
srcs = glob(include = ["src/builders/dev-server/tests/**/*.ts"]),
190+
# TODO: Fix strict_deps failure
191+
ignore_strict_deps = True,
184192
deps = [
185193
":build_rjs",
186194
"//packages/angular/build/private:private_rjs",
@@ -213,6 +221,8 @@ ts_project(
213221
name = "karma_integration_test_lib",
214222
testonly = True,
215223
srcs = glob(include = ["src/builders/karma/tests/**/*.ts"]),
224+
# TODO: Fix strict_deps failure
225+
ignore_strict_deps = True,
216226
deps = [
217227
":build_rjs",
218228
"//packages/angular/build/private:private_rjs",

‎packages/angular/cli/BUILD.bazel‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,8 @@ ts_project(
107107
"node_modules/**",
108108
],
109109
),
110+
# TODO: Fix strict_deps failure
111+
ignore_strict_deps = True,
110112
deps = [
111113
":angular-cli_rjs",
112114
"//:node_modules/@types/semver",

‎packages/angular/pwa/BUILD.bazel‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ ts_project(
5050
name = "pwa_test_lib",
5151
testonly = True,
5252
srcs = glob(["pwa/**/*_spec.ts"]),
53+
# TODO: Fix strict_deps failure
54+
ignore_strict_deps = True,
5355
deps = [
5456
":pwa_rjs",
5557
"//:node_modules/@types/jasmine",

‎packages/angular/ssr/node/BUILD.bazel‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ ts_project(
1414
"--types",
1515
"node",
1616
],
17+
# TODO: Fix strict_deps failure
18+
ignore_strict_deps = True,
1719
module_name = "@angular/ssr/node",
1820
source_map = True,
1921
tsconfig = "//:build-tsconfig-esm",

‎packages/angular_devkit/architect/testing/BUILD.bazel‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ ts_project(
1515
include = ["**/*.ts"],
1616
exclude = ["**/*_spec.ts"],
1717
),
18+
# TODO: Fix strict_deps failure
19+
ignore_strict_deps = True,
1820
module_name = "@angular-devkit/architect/testing",
1921
deps = [
2022
"//:node_modules/@types/node",

‎packages/angular_devkit/build_angular/BUILD.bazel‎

Lines changed: 35 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,8 @@ ts_project(
127127
"//packages/angular_devkit/build_angular:src/builders/web-test-runner/schema.ts",
128128
],
129129
data = RUNTIME_ASSETS,
130+
# TODO: Fix strict_deps failure
131+
ignore_strict_deps = True,
130132
module_name = "@angular-devkit/build-angular",
131133
deps = [
132134
":node_modules/@angular-devkit/architect",
@@ -223,6 +225,8 @@ ts_project(
223225
data = [
224226
"//packages/angular_devkit/build_angular/test/hello-world-lib",
225227
],
228+
# TODO: Fix strict_deps failure
229+
ignore_strict_deps = True,
226230
deps = [
227231
":build_angular_rjs",
228232
":build_angular_test_utils_rjs",
@@ -294,6 +298,8 @@ ts_project(
294298
data = [
295299
"//packages/angular_devkit/build_angular/test/hello-world-lib",
296300
],
301+
# TODO: Fix strict_deps failure
302+
ignore_strict_deps = True,
297303
deps = [
298304
":build_angular_rjs",
299305
"//:node_modules/@types/jasmine",
@@ -309,8 +315,13 @@ ts_project(
309315
)
310316

311317
LARGE_SPECS = {
312-
"app-shell": {},
318+
"app-shell": {
319+
# TODO: Fix strict_deps failure
320+
"ignore_strict_deps": True,
321+
},
313322
"dev-server": {
323+
# TODO: Fix strict_deps failure
324+
"ignore_strict_deps": True,
314325
"shards": 10,
315326
"size": "large",
316327
"flaky": True,
@@ -322,8 +333,13 @@ LARGE_SPECS = {
322333
"//:node_modules/undici",
323334
],
324335
},
325-
"extract-i18n": {},
336+
"extract-i18n": {
337+
# TODO: Fix strict_deps failure
338+
"ignore_strict_deps": True,
339+
},
326340
"karma": {
341+
# TODO: Fix strict_deps failure
342+
"ignore_strict_deps": True,
327343
"shards": 6,
328344
"size": "large",
329345
"flaky": True,
@@ -338,6 +354,8 @@ LARGE_SPECS = {
338354
],
339355
},
340356
"protractor": {
357+
# TODO: Fix strict_deps failure
358+
"ignore_strict_deps": True,
341359
"extra_deps": [
342360
"//:node_modules/jasmine-spec-reporter",
343361
"//:node_modules/protractor",
@@ -350,13 +368,20 @@ LARGE_SPECS = {
350368
"shards": 1,
351369
},
352370
"server": {
371+
# TODO: Fix strict_deps failure
372+
"ignore_strict_deps": True,
353373
"size": "large",
354374
"extra_deps": [
355375
"//:node_modules/@angular/animations",
356376
],
357377
},
358-
"ng-packagr": {},
378+
"ng-packagr": {
379+
# TODO: Fix strict_deps failure
380+
"ignore_strict_deps": True,
381+
},
359382
"browser": {
383+
# TODO: Fix strict_deps failure
384+
"ignore_strict_deps": True,
360385
"shards": 10,
361386
"size": "large",
362387
"flaky": True,
@@ -365,9 +390,14 @@ LARGE_SPECS = {
365390
"//:node_modules/@angular/material",
366391
],
367392
},
368-
"prerender": {},
393+
"prerender": {
394+
# TODO: Fix strict_deps failure
395+
"ignore_strict_deps": True,
396+
},
369397
"browser-esbuild": {},
370398
"ssr-dev-server": {
399+
# TODO: Fix strict_deps failure
400+
"ignore_strict_deps": True,
371401
"extra_deps": [
372402
"//packages/angular/ssr/node:node_rjs",
373403
"//:node_modules/@types/browser-sync",
@@ -383,6 +413,7 @@ LARGE_SPECS = {
383413
name = "build_angular_" + spec + "_test_lib",
384414
testonly = True,
385415
srcs = glob(["src/builders/" + spec + "/**/*_spec.ts"]),
416+
ignore_strict_deps = LARGE_SPECS[spec].get("ignore_strict_deps", False),
386417
deps = [
387418
# Dependencies needed to compile and run the specs themselves.
388419
":build_angular_rjs",

‎packages/angular_devkit/schematics/BUILD.bazel‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ ts_project(
3939
name = "schematics_test_lib",
4040
testonly = True,
4141
srcs = glob(["src/**/*_spec.ts"]),
42+
# TODO: Fix strict_deps failure
43+
ignore_strict_deps = True,
4244
deps = [
4345
":node_modules/@angular-devkit/core",
4446
":schematics",

‎packages/angular_devkit/schematics/tasks/BUILD.bazel‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ ts_project(
1818
],
1919
),
2020
data = ["package.json"],
21+
# TODO: Fix strict_deps failure
22+
ignore_strict_deps = True,
2123
module_name = "@angular-devkit/schematics/tasks",
2224
deps = [
2325
"//:node_modules/@types/node",

‎packages/angular_devkit/schematics/testing/BUILD.bazel‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ ts_project(
1414
include = ["**/*.ts"],
1515
),
1616
data = ["package.json"],
17+
# TODO: Fix strict_deps failure
18+
ignore_strict_deps = True,
1719
module_name = "@angular-devkit/schematics/testing",
1820
deps = [
1921
"//:node_modules/rxjs",

‎packages/schematics/angular/BUILD.bazel‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,8 @@ ts_project(
8686
for (src, _) in ALL_SCHEMA_TARGETS
8787
],
8888
data = RUNTIME_ASSETS,
89+
# TODO: Fix strict_deps failure
90+
ignore_strict_deps = True,
8991
module_name = "@schematics/angular",
9092
deps = [
9193
":node_modules/@angular-devkit/core",

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /