Commit c8c7318

clydinalan-agius4

authored and

committed

fix(@angular/build): ensure matching coverage excludes with karma on Windows

When on Windows, the coverage exclusion paths need to be made absolute via the Node.js path builtin to ensure matching with the files during the build process.

1 parent c39c344 commit c8c7318Copy full SHA for c8c7318

File tree

1 file changed

-1

lines changed

packages/angular/build/src/builders/karma
- application_builder.ts

1 file changed

-1

lines changed

`‎packages/angular/build/src/builders/karma/application_builder.ts‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -614,7 +614,7 @@ function getInstrumentationExcludedPaths(root: string, excludedPaths: string[]):`
`614`	`614`
`615`	`615`	`for (const excludeGlob of excludedPaths) {`
`616`	`616`	`const excludePath = excludeGlob[0] === '/' ? excludeGlob.slice(1) : excludeGlob;`
`617`		`- globSync(excludePath, { absolute: true,cwd: root }).forEach((p) => excluded.add(p));`
	`617`	`+ globSync(excludePath, { cwd: root }).forEach((p) => excluded.add(path.join(root,p)));`
`618`	`618`	`}`
`619`	`619`
`620`	`620`	`return excluded;`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit c8c7318

File tree

1 file changed

1 file changed

`‎packages/angular/build/src/builders/karma/application_builder.ts‎`

0 commit comments