Commit c4cf359

committed

fix(@angular/build): print Sass @warn location

When using the `@warn` directive, the `span` entry in the warning object is often undefined. Instead, the `stack` property is populated. ```js { "warnings": [ { "deprecation": false, "deprecationType": null, "span": undefined, "stack": "projects/foo/src/app/app.component.scss 1:1 root stylesheet\n", "message": "some message" } ] } ``` ### Before ``` ▲さんかく [WARNING] some message [plugin angular-sass] ``` ### Now ``` ▲さんかく [WARNING] some message [plugin angular-sass] projects/foo/src/app/app.component.scss 1:1 root stylesheet ``` Closes: #27726 (cherry picked from commit 4a879a9)

1 parent acbffd2 commit c4cf359Copy full SHA for c4cf359

File tree

1 file changed

+11

-3

lines changed

packages/angular/build/src/tools/esbuild/stylesheets
- sass-language.ts

1 file changed

+11

-3

lines changed

`‎packages/angular/build/src/tools/esbuild/stylesheets/sass-language.ts‎`

Lines changed: 11 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`* found in the LICENSE file at https://angular.io/license`
`7`	`7`	`*/`
`8`	`8`
`9`		`-import type { OnLoadResult, PartialMessage, ResolveResult } from 'esbuild';`
	`9`	`+import type { OnLoadResult, PartialMessage, PartialNote,ResolveResult } from 'esbuild';`
`10`	`10`	`import { dirname, join, relative } from 'node:path';`
`11`	`11`	`import { fileURLToPath, pathToFileURL } from 'node:url';`
`12`	`12`	`import type { CanonicalizeContext, CompileResult, Exception, Syntax } from 'sass';`
`@@ -140,7 +140,15 @@ async function compileString(`
`140`	`140`	`},`
`141`	`141`	`],`
`142`	`142`	`logger: {`
`143`		`- warn: (text, { deprecation, span }) => {`
	`143`	`+ warn: (text, { deprecation, stack, span }) => {`
	`144`	`+ const notes: PartialNote[] = [];`
	`145`	`+ if (deprecation) {`
	`146`	`+ notes.push({ text });`
	`147`	`+ }`
	`148`	`+ if (stack && !span) {`
	`149`	`+ notes.push({ text: stack });`
	`150`	`+ }`
	`151`	`+`
`144`	`152`	`warnings.push({`
`145`	`153`	`text: deprecation ? 'Deprecation' : text,`
`146`	`154`	`location: span && {`
`@@ -150,7 +158,7 @@ async function compileString(`
`150`	`158`	`line: span.start.line + 1,`
`151`	`159`	`column: span.start.column,`
`152`	`160`	`},`
`153`		`- notes: deprecation ? [{ text }] : undefined,`
	`161`	`+ notes,`
`154`	`162`	`});`
`155`	`163`	`},`
`156`	`164`	`},`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit c4cf359

File tree

1 file changed

1 file changed

`‎packages/angular/build/src/tools/esbuild/stylesheets/sass-language.ts‎`

0 commit comments