Skip to content

Commit 8f038de

committed

refactor(@angular-devkit/build-angular): remove implicit localize polyfill

In the v19 application builder, the localize polyfill should not be added implicitly. See: d6a3403

1 parent bd52d11 commit 8f038deCopy full SHA for 8f038de

File tree

14 files changed

+34

-43

lines changed

packages/angular_devkit/build_angular/src/builders/karma
- application_builder.ts
- tests

14 files changed

+34

-43

lines changed

`‎packages/angular_devkit/build_angular/src/builders/karma/application_builder.ts‎`

Lines changed: 0 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,6 @@ import {`
`12`	`12`	`ResultKind,`
`13`	`13`	`buildApplicationInternal,`
`14`	`14`	`emitFilesToDisk,`
`15`		`- purgeStaleBuildCache,`
`16`	`15`	`} from '@angular/build/private';`
`17`	`16`	`import { BuilderContext, BuilderOutput } from '@angular-devkit/architect';`
`18`	`17`	`import { randomUUID } from 'crypto';`
`@@ -22,7 +21,6 @@ import * as path from 'path';`
`22`	`21`	`import { Observable, catchError, defaultIfEmpty, from, of, switchMap } from 'rxjs';`
`23`	`22`	`import { Configuration } from 'webpack';`
`24`	`23`	`import { ExecutionTransformer } from '../../transforms';`
`25`		`-import { readTsconfig } from '../../utils/read-tsconfig';`
`26`	`24`	`import { OutputHashing } from '../browser-esbuild/schema';`
`27`	`25`	`import { findTests } from './find-tests';`
`28`	`26`	`import { Schema as KarmaBuilderOptions } from './schema';`
`@@ -110,18 +108,6 @@ async function collectEntrypoints(`
`110`	`108`	`entryPoints.add('zone.js/testing');`
`111`	`109`	`}`
`112`	`110`
`113`		`- const tsConfigPath = path.resolve(context.workspaceRoot, options.tsConfig);`
`114`		`- const tsConfig = await readTsconfig(tsConfigPath);`
`115`		`-`
`116`		`- const localizePackageInitEntryPoint = '@angular/localize/init';`
`117`		`- const hasLocalizeType = tsConfig.options.types?.some(`
`118`		`- (t) => t === '@angular/localize' \|\| t === localizePackageInitEntryPoint,`
`119`		`- );`
`120`		`-`
`121`		`- if (hasLocalizeType) {`
`122`		`- polyfills.push(localizePackageInitEntryPoint);`
`123`		`- }`
`124`		`-`
`125`	`111`	`return [entryPoints, polyfills];`
`126`	`112`	`}`
`127`	`113`

`‎packages/angular_devkit/build_angular/src/builders/karma/tests/behavior/code-coverage_spec.ts‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,8 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget, isAppli`
`29`	`29`	`});`
`30`	`30`	`}`
`31`	`31`
`32`		`- beforeEach(() => {`
`33`		`- setupTarget(harness);`
	`32`	`+ beforeEach(async() => {`
	`33`	`+ awaitsetupTarget(harness);`
`34`	`34`	`});`
`35`	`35`
`36`	`36`	`it('should generate coverage report when file was previously processed by Babel', async () => {`

`‎packages/angular_devkit/build_angular/src/builders/karma/tests/behavior/errors_spec.ts‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,8 @@ import { BASE_OPTIONS, KARMA_BUILDER_INFO, describeKarmaBuilder } from '../setup`
`11`	`11`
`12`	`12`	`describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {`
`13`	`13`	`describe('Behavior: "Errors"', () => {`
`14`		`- beforeEach(() => {`
`15`		`- setupTarget(harness);`
	`14`	`+ beforeEach(async() => {`
	`15`	`+ awaitsetupTarget(harness);`
`16`	`16`	`});`
`17`	`17`
`18`	`18`	`it('should fail when there is a TypeScript error', async () => {`

`‎packages/angular_devkit/build_angular/src/builders/karma/tests/behavior/module-cjs_spec.ts‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,8 @@ import { BASE_OPTIONS, KARMA_BUILDER_INFO, describeKarmaBuilder } from '../setup`
`11`	`11`
`12`	`12`	`describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {`
`13`	`13`	`describe('Behavior: "module commonjs"', () => {`
`14`		`- beforeEach(() => {`
`15`		`- setupTarget(harness);`
	`14`	`+ beforeEach(async() => {`
	`15`	`+ awaitsetupTarget(harness);`
`16`	`16`	`});`
`17`	`17`
`18`	`18`	`it('should work when module is commonjs', async () => {`

`‎packages/angular_devkit/build_angular/src/builders/karma/tests/behavior/rebuilds_spec.ts‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,8 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget, isAppli`
`18`	`18`	`});`
`19`	`19`	`}`
`20`	`20`
`21`		`- beforeEach(() => {`
`22`		`- setupTarget(harness);`
	`21`	`+ beforeEach(async() => {`
	`22`	`+ awaitsetupTarget(harness);`
`23`	`23`	`});`
`24`	`24`
`25`	`25`	`it('recovers from compilation failures in watch mode', async () => {`

`‎packages/angular_devkit/build_angular/src/builders/karma/tests/options/assets_spec.ts‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,8 @@ import { BASE_OPTIONS, KARMA_BUILDER_INFO, describeKarmaBuilder } from '../setup`
`11`	`11`
`12`	`12`	`describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {`
`13`	`13`	`describe('Option: "assets"', () => {`
`14`		`- beforeEach(() => {`
`15`		`- setupTarget(harness);`
	`14`	`+ beforeEach(async() => {`
	`15`	`+ awaitsetupTarget(harness);`
`16`	`16`	`});`
`17`	`17`
`18`	`18`	`it('includes assets', async () => {`

`‎packages/angular_devkit/build_angular/src/builders/karma/tests/options/builder-mode_spec.ts‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,13 +14,15 @@ const ESBUILD_LOG_TEXT = 'Application bundle generation complete.';`
`14`	`14`
`15`	`15`	`describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget, isApplicationTarget) => {`
`16`	`16`	`describe('option: "builderMode"', () => {`
`17`		`- beforeEach(() => {`
`18`		`- setupTarget(harness);`
	`17`	`+ beforeEach(async() => {`
	`18`	`+ awaitsetupTarget(harness);`
`19`	`19`	`});`
`20`	`20`
`21`	`21`	`it('"application" always uses esbuild', async () => {`
`22`	`22`	`harness.useTarget('test', {`
`23`	`23`	`...BASE_OPTIONS,`
	`24`	`+ // Must explicitly provide localize polyfill:`
	`25`	`+ polyfills: ['zone.js', '@angular/localize/init', 'zone.js/testing'],`
`24`	`26`	`builderMode: BuilderMode.Application,`
`25`	`27`	`});`
`26`	`28`

`‎packages/angular_devkit/build_angular/src/builders/karma/tests/options/code-coverage-exclude_spec.ts‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,8 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget, isAppli`
`26`	`26`	`});`
`27`	`27`	`}`
`28`	`28`
`29`		`- beforeEach(() => {`
`30`		`- setupTarget(harness);`
	`29`	`+ beforeEach(async() => {`
	`30`	`+ awaitsetupTarget(harness);`
`31`	`31`	`});`
`32`	`32`
`33`	`33`	`it('should exclude file from coverage when set', async () => {`

`‎packages/angular_devkit/build_angular/src/builders/karma/tests/options/code-coverage_spec.ts‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,8 @@ describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget, isAppli`
`27`	`27`	`});`
`28`	`28`	`}`
`29`	`29`
`30`		`- beforeEach(() => {`
`31`		`- setupTarget(harness);`
	`30`	`+ beforeEach(async() => {`
	`31`	`+ awaitsetupTarget(harness);`
`32`	`32`	`});`
`33`	`33`
`34`	`34`	`it('should generate coverage report when option is set to true', async () => {`

`‎packages/angular_devkit/build_angular/src/builders/karma/tests/options/exclude_spec.ts‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,8 @@ import { BASE_OPTIONS, KARMA_BUILDER_INFO, describeKarmaBuilder } from '../setup`
`11`	`11`
`12`	`12`	`describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {`
`13`	`13`	`describe('Option: "exclude"', () => {`
`14`		`- beforeEach(() => {`
`15`		`- setupTarget(harness);`
	`14`	`+ beforeEach(async() => {`
	`15`	`+ awaitsetupTarget(harness);`
`16`	`16`	`});`
`17`	`17`
`18`	`18`	`beforeEach(async () => {`

0 commit comments

Comments

(0)