Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 7a2d0e5

Browse files
alan-agius4clydin
authored andcommitted
refactor(@angular/build): remove experimental buildApplication overload
An experimental overload of `buildApplication` has been removed. (cherry picked from commit a3e2bcd)
1 parent 9ad8514 commit 7a2d0e5

File tree

3 files changed

+10
-40
lines changed

3 files changed

+10
-40
lines changed

‎goldens/public-api/angular/build/index.api.md‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,14 @@ import type http from 'node:http';
1010
import { OutputFile } from 'esbuild';
1111
import type { Plugin as Plugin_2 } from 'esbuild';
1212

13+
// @public (undocumented)
14+
export interface ApplicationBuilderExtensions {
15+
// (undocumented)
16+
codePlugins?: Plugin_2[];
17+
// (undocumented)
18+
indexHtmlTransformer?: IndexHtmlTransform;
19+
}
20+
1321
// @public
1422
export interface ApplicationBuilderOptions {
1523
allowedCommonJsDependencies?: string[];
@@ -74,9 +82,6 @@ export interface ApplicationBuilderOutput extends BuilderOutput {
7482
outputFiles?: BuildOutputFile[];
7583
}
7684

77-
// @public
78-
export function buildApplication(options: ApplicationBuilderOptions, context: BuilderContext, plugins?: Plugin_2[]): AsyncIterable<ApplicationBuilderOutput>;
79-
8085
// @public
8186
export function buildApplication(options: ApplicationBuilderOptions, context: BuilderContext, extensions?: ApplicationBuilderExtensions): AsyncIterable<ApplicationBuilderOutput>;
8287

‎packages/angular/build/src/builders/application/index.ts‎

Lines changed: 1 addition & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
*/
88

99
import { BuilderContext, BuilderOutput, createBuilder } from '@angular-devkit/architect';
10-
import type { Plugin } from 'esbuild';
1110
import assert from 'node:assert';
1211
import fs from 'node:fs/promises';
1312
import path from 'node:path';
@@ -138,26 +137,6 @@ export interface ApplicationBuilderOutput extends BuilderOutput {
138137
assetFiles?: { source: string; destination: string }[];
139138
}
140139

141-
/**
142-
* Builds an application using the `application` builder with the provided
143-
* options.
144-
*
145-
* Usage of the `plugins` parameter is NOT supported and may cause unexpected
146-
* build output or build failures.
147-
*
148-
* @experimental Direct usage of this function is considered experimental.
149-
*
150-
* @param options The options defined by the builder's schema to use.
151-
* @param context An Architect builder context instance.
152-
* @param plugins An array of plugins to apply to the main code bundling.
153-
* @returns The build output results of the build.
154-
*/
155-
export function buildApplication(
156-
options: ApplicationBuilderOptions,
157-
context: BuilderContext,
158-
plugins?: Plugin[],
159-
): AsyncIterable<ApplicationBuilderOutput>;
160-
161140
/**
162141
* Builds an application using the `application` builder with the provided
163142
* options.
@@ -172,26 +151,11 @@ export function buildApplication(
172151
* @param extensions An object contain extension points for the build.
173152
* @returns The build output results of the build.
174153
*/
175-
export function buildApplication(
176-
options: ApplicationBuilderOptions,
177-
context: BuilderContext,
178-
extensions?: ApplicationBuilderExtensions,
179-
): AsyncIterable<ApplicationBuilderOutput>;
180-
181154
export async function* buildApplication(
182155
options: ApplicationBuilderOptions,
183156
context: BuilderContext,
184-
pluginsOrExtensions?: Plugin[]| ApplicationBuilderExtensions,
157+
extensions?: ApplicationBuilderExtensions,
185158
): AsyncIterable<ApplicationBuilderOutput> {
186-
let extensions: ApplicationBuilderExtensions | undefined;
187-
if (pluginsOrExtensions && Array.isArray(pluginsOrExtensions)) {
188-
extensions = {
189-
codePlugins: pluginsOrExtensions,
190-
};
191-
} else {
192-
extensions = pluginsOrExtensions;
193-
}
194-
195159
let initial = true;
196160
for await (const result of buildApplicationInternal(options, context, extensions)) {
197161
const outputOptions = result.detail?.['outputOptions'] as NormalizedOutputOptions | undefined;

‎packages/angular/build/src/index.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export {
1111
type ApplicationBuilderOptions,
1212
type ApplicationBuilderOutput,
1313
} from './builders/application';
14+
export type { ApplicationBuilderExtensions } from './builders/application/options';
1415
export { type BuildOutputFile, BuildOutputFileType } from './tools/esbuild/bundler-context';
1516
export type { BuildOutputAsset } from './tools/esbuild/bundler-execution-result';
1617

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /