Commit 77e1adc

clydinalan-agius4

authored and

committed

refactor(@schematics/angular): remove manual install task in library schematic

Removes the manual `NodePackageInstallTask` from the library schematic. The responsibility for scheduling the installation is now delegated to the `addDependency` utility by passing the correct `InstallBehavior`. This makes the schematic cleaner and more consistent with the `application` schematic.

1 parent 9723844 commit 77e1adcCopy full SHA for 77e1adc

File tree

1 file changed

-9

lines changed

packages/schematics/angular/library
- index.ts

1 file changed

-9

lines changed

`‎packages/schematics/angular/library/index.ts`

Lines changed: 5 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@`
`8`	`8`
`9`	`9`	`import {`
`10`	`10`	`Rule,`
`11`		`- SchematicContext,`
`12`	`11`	`Tree,`
`13`	`12`	`apply,`
`14`	`13`	`applyTemplates,`
`@@ -20,11 +19,11 @@ import {`
`20`	`19`	`strings,`
`21`	`20`	`url,`
`22`	`21`	`} from '@angular-devkit/schematics';`
`23`		`-import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks';`
`24`	`22`	`import { join } from 'node:path/posix';`
`25`	`23`	`import {`
`26`	`24`	`DependencyType,`
`27`	`25`	`ExistingBehavior,`
	`26`	`+ InstallBehavior,`
`28`	`27`	`addDependency,`
`29`	`28`	`getDependency,`
`30`	`29`	`} from '../utility/dependency';`
`@@ -70,17 +69,19 @@ function addTsProjectReference(...paths: string[]) {`
`70`	`69`	`};`
`71`	`70`	`}`
`72`	`71`
`73`		`-function addDependenciesToPackageJson(): Rule {`
	`72`	`+function addDependenciesToPackageJson(skipInstall: boolean): Rule {`
`74`	`73`	`return chain([`
`75`	`74`	`...LIBRARY_DEV_DEPENDENCIES.map((dependency) =>`
`76`	`75`	`addDependency(dependency.name, dependency.version, {`
`77`	`76`	`type: DependencyType.Dev,`
`78`	`77`	`existing: ExistingBehavior.Skip,`
	`78`	`+ install: skipInstall ? InstallBehavior.None : InstallBehavior.Auto,`
`79`	`79`	`}),`
`80`	`80`	`),`
`81`	`81`	`addDependency('tslib', latestVersions['tslib'], {`
`82`	`82`	`type: DependencyType.Default,`
`83`	`83`	`existing: ExistingBehavior.Skip,`
	`84`	`+ install: skipInstall ? InstallBehavior.None : InstallBehavior.Auto,`
`84`	`85`	`}),`
`85`	`86`	`]);`
`86`	`87`	`}`
`@@ -171,7 +172,7 @@ export default function (options: LibraryOptions): Rule {`
`171`	`172`	`return chain([`
`172`	`173`	`mergeWith(templateSource),`
`173`	`174`	`addLibToWorkspaceFile(options, libDir, packageName, hasZoneDependency),`
`174`		`- options.skipPackageJson ? noop() : addDependenciesToPackageJson(),`
	`175`	`+ options.skipPackageJson ? noop() : addDependenciesToPackageJson(!!options.skipInstall),`
`175`	`176`	`options.skipTsConfig ? noop() : updateTsConfig(packageName, './' + distRoot),`
`176`	`177`	`options.skipTsConfig`
`177`	`178`	`? noop()`
`@@ -203,11 +204,6 @@ export default function (options: LibraryOptions): Rule {`
`203`	`204`	// inherits its `type` from the workspace.
`204`	`205`	`type: '',`
`205`	`206`	`}),`
`206`		`- (_tree: Tree, context: SchematicContext) => {`
`207`		`- if (!options.skipPackageJson && !options.skipInstall) {`
`208`		`- context.addTask(new NodePackageInstallTask());`
`209`		`- }`
`210`		`- },`
`211`	`207`	`]);`
`212`	`208`	`};`
`213`	`209`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 77e1adc

File tree

1 file changed

1 file changed

`‎packages/schematics/angular/library/index.ts`

0 commit comments