Commit 6c7b798

committed

fix(@schematics/angular): directly resolve karma config template in migration

To attempt to workaround Windows pathing issues in the karma configuration migration, the default karma template is now resolved via `require.resolve`.

1 parent a1ef96b commit 6c7b798Copy full SHA for 6c7b798

File tree

2 files changed

-1

lines changed

packages/schematics/angular/migrations
- karma
  - karma-config-comparer.ts
- migration-collection.json

2 files changed

-1

lines changed

`‎packages/schematics/angular/migrations/karma/karma-config-comparer.ts‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ export async function generateDefaultKarmaConfig(`
`41`	`41`	`projectName: string,`
`42`	`42`	`needDevkitPlugin: boolean,`
`43`	`43`	`): Promise<string> {`
`44`		`- const templatePath = path.join(__dirname,'../../config/files/karma.conf.js.template');`
	`44`	`+ const templatePath = require.resolve('../../config/files/karma.conf.js.template');`
`45`	`45`	`let template = await readFile(templatePath, 'utf-8');`
`46`	`46`
`47`	`47`	`// TODO: Replace this with the actual schematic templating logic.`

`‎packages/schematics/angular/migrations/migration-collection.json‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`{`
	`2`	`+ "encapsulation": false,`
`2`	`3`	`"schematics": {`
`3`	`4`	`"use-application-builder": {`
`4`	`5`	`"version": "21.0.0",`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 6c7b798

File tree

2 files changed

2 files changed

`‎packages/schematics/angular/migrations/karma/karma-config-comparer.ts‎`

`‎packages/schematics/angular/migrations/migration-collection.json‎`

0 commit comments