Commit 3ce086a

devversionalan-agius4

authored and

committed

test: improve stability of strategy tests

The strategy tests are extremely time-sensitive with regards to the RxJS job logic executing, and the tests currently rely on `setImmediate` to flush/trigger job execution. This seems to be rather unstable via Remote execution, and sensitive to changes with the execution (e.g. injecting source map support or not), so we are stabilizing the tests further by having better time delays for job execution, and by using `setTimeout` for flushing. This seems very sufficient.

1 parent 2114f02 commit 3ce086aCopy full SHA for 3ce086a

File tree

1 file changed

-7

lines changed

packages/angular_devkit/architect/src/jobs
- strategy_spec.ts

1 file changed

-7

lines changed

`‎packages/angular_devkit/architect/src/jobs/strategy_spec.ts‎`

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,14 +6,14 @@`
`6`	`6`	`* found in the LICENSE file at https://angular.dev/license`
`7`	`7`	`*/`
`8`	`8`
`9`		`-import {promisify}from 'util';`
	`9`	`+import timersfrom 'node:timers/promises';`
`10`	`10`	`import { JobState } from './api';`
`11`	`11`	`import { createJobHandler } from './create-job-handler';`
`12`	`12`	`import { SimpleJobRegistry } from './simple-registry';`
`13`	`13`	`import { SimpleScheduler } from './simple-scheduler';`
`14`	`14`	`import * as strategy from './strategy';`
`15`	`15`
`16`		`-const flush = promisify(setImmediate);`
	`16`	`+const flush = ()=>timers.setTimeout(1);`
`17`	`17`
`18`	`18`	`describe('strategy.serialize()', () => {`
`19`	`19`	`let registry: SimpleJobRegistry;`
`@@ -37,7 +37,7 @@ describe('strategy.serialize()', () => {`
`37`	`37`	`setTimeout(() => {`
`38`	`38`	`finished++;`
`39`	`39`	`resolve(input.reduce((a, c) => a + c, 0));`
`40`		`- }, 10),`
	`40`	`+ }, 100),`
`41`	`41`	`);`
`42`	`42`	`// eslint-disable-next-line @typescript-eslint/no-explicit-any`
`43`	`43`	`}) as any,`
`@@ -94,7 +94,7 @@ describe('strategy.serialize()', () => {`
`94`	`94`	`setTimeout(() => {`
`95`	`95`	`finished++;`
`96`	`96`	`resolve(input.reduce((a, c) => a + c, 0));`
`97`		`- }, 10),`
	`97`	`+ }, 100),`
`98`	`98`	`);`
`99`	`99`	`// eslint-disable-next-line @typescript-eslint/no-explicit-any`
`100`	`100`	`}) as any,`
`@@ -114,7 +114,7 @@ describe('strategy.serialize()', () => {`
`114`	`114`	`setTimeout(() => {`
`115`	`115`	`finished++;`
`116`	`116`	`resolve(input.reduce((a, c) => a + c, 100));`
`117`		`- }, 10),`
	`117`	`+ }, 100),`
`118`	`118`	`);`
`119`	`119`	`// eslint-disable-next-line @typescript-eslint/no-explicit-any`
`120`	`120`	`}) as any,`
`@@ -179,7 +179,7 @@ describe('strategy.reuse()', () => {`
`179`	`179`	`setTimeout(() => {`
`180`	`180`	`finished++;`
`181`	`181`	`resolve(input.reduce((a, c) => a + c, 0));`
`182`		`- }, 10),`
	`182`	`+ }, 100),`
`183`	`183`	`);`
`184`	`184`	`// eslint-disable-next-line @typescript-eslint/no-explicit-any`
`185`	`185`	`}) as any,`
`@@ -254,7 +254,7 @@ describe('strategy.memoize()', () => {`
`254`	`254`	`setTimeout(() => {`
`255`	`255`	`finished++;`
`256`	`256`	`resolve(input.reduce((a, c) => a + c, 0));`
`257`		`- }, 10),`
	`257`	`+ }, 100),`
`258`	`258`	`);`
`259`	`259`	`// eslint-disable-next-line @typescript-eslint/no-explicit-any`
`260`	`260`	`}) as any,`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 3ce086a

File tree

1 file changed

1 file changed

`‎packages/angular_devkit/architect/src/jobs/strategy_spec.ts‎`

0 commit comments