Commit 01b082a

Charles Lydingfilipesilva

Charles Lyding

authored and

committed

refactor(@angular/cli): remove unnecessary use of ember-cli promise wrapper

1 parent 390c624 commit 01b082aCopy full SHA for 01b082a

File tree

-16

lines changed

-16

lines changed

Lines changed: 5 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,16 +1,11 @@`
`1`		`-'use strict';`
`2`		`-`
`3`	`1`	`// This needs to be first so fs module can be mocked correctly.`
`4`		`-let mockFs = require('mock-fs');`
`5`		`-`
`6`		`-import {it} from './spec-utils';`
`7`		`-import {InsertChange, NodeHost, RemoveChange, ReplaceChange} from './change';`
`8`		`-import fs = require('fs');`
	`2`	`+import mockFs = require('mock-fs');`
`9`	`3`
`10`		`-let path = require('path');`
`11`		`-let Promise = require('@angular/cli/ember-cli/lib/ext/promise');`
	`4`	`+import { it } from './spec-utils';`
	`5`	`+import { InsertChange, NodeHost, RemoveChange, ReplaceChange } from './change';`
	`6`	`+import { readFile } from 'fs-extra';`
	`7`	`+import * as path from 'path';`
`12`	`8`
`13`		`-const readFile = Promise.denodeify(fs.readFile);`
`14`	`9`
`15`	`10`	`describe('Change', () => {`
`16`	`11`	`let sourcePath = 'src/app/my-component';`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`import { oneLine } from 'common-tags';`
	`2`	`+import denodeify = require('denodeify');`
`2`	`3`
`3`		`-const Promise = require('../ember-cli/lib/ext/promise');`
`4`		`-const exec = Promise.denodeify(require('child_process').exec);`
	`4`	`+const exec: any = denodeify(require('child_process').exec);`
`5`	`5`	`const path = require('path');`
`6`	`6`	`const pkg = require('../package.json');`
`7`	`7`	`const fs = require('fs');`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,9 @@`
`1`	`1`	`import * as chalk from 'chalk';`
`2`	`2`	`import {exec} from 'child_process';`
`3`	`3`	`import {CliConfig} from '../models/config';`
	`4`	`+import denodeify = require('denodeify');`
`4`	`5`
`5`		`-const Promise = require('../ember-cli/lib/ext/promise');`
`6`		`-const execPromise = Promise.denodeify(exec);`
	`6`	`+const execPromise = denodeify(exec);`
`7`	`7`	`const packageManager = CliConfig.fromGlobal().get('packageManager');`
`8`	`8`
`9`	`9`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,8 +5,6 @@ import { expectFileToExist } from '../../../utils/fs';`
`5`	`5`	`import { expectToFail } from '../../../utils/utils';`
`6`	`6`
`7`	`7`
`8`		`-const Promise = require('@angular/cli/ember-cli/lib/ext/promise');`
`9`		`-`
`10`	`8`	`export default function () {`
`11`	`9`	`const root = process.cwd();`
`12`	`10`	`const testPath = join(root, 'src', 'app');`

Comments

(0)