Commit 988e02b

committed

Refactor UserModule to use constant for injection rather than string literals.

1 parent f433db9 commit 988e02bCopy full SHA for 988e02b

File tree

+11

-5

lines changed

domain/src/main/java/com/fernandocejas/android10/sample/domain/interactor
- GetUserDetails.java
- GetUserList.java
presentation/src/main/java/com/fernandocejas/android10/sample/presentation
- internal/di/modules
  - UserModule.java
- presenter
  - UserDetailsPresenter.java
  - UserListPresenter.java

+11

-5

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,8 @@`
`28`	`28`	`*/`
`29`	`29`	`public class GetUserDetails extends UseCase {`
`30`	`30`
	`31`	`+ public static final String NAME = "userDetails";`
	`32`	`+`
`31`	`33`	`private final int userId;`
`32`	`34`	`private final UserRepository userRepository;`
`33`	`35`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,8 @@`
`28`	`28`	`*/`
`29`	`29`	`public class GetUserList extends UseCase {`
`30`	`30`
	`31`	`+ public static final String NAME = "userList";`
	`32`	`+`
`31`	`33`	`private final UserRepository userRepository;`
`32`	`34`
`33`	`35`	`@Inject`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,14 +40,14 @@ public UserModule(int userId) {`
`40`	`40`	`this.userId = userId;`
`41`	`41`	`}`
`42`	`42`
`43`		`- @Provides @PerActivity @Named("userList") UseCase provideGetUserListUseCase(`
	`43`	`+ @Provides @PerActivity @Named(GetUserList.NAME) UseCase provideGetUserListUseCase(`
`44`	`44`	`GetUserList getUserList) {`
`45`	`45`	`return getUserList;`
`46`	`46`	`}`
`47`	`47`
`48`		`- @Provides @PerActivity @Named("userDetails") UseCase provideGetUserDetailsUseCase(`
	`48`	`+ @Provides @PerActivity @Named(GetUserDetails.NAME) UseCase provideGetUserDetailsUseCase(`
`49`	`49`	`UserRepository userRepository, ThreadExecutor threadExecutor,`
`50`	`50`	`PostExecutionThread postExecutionThread) {`
`51`	`51`	`return new GetUserDetails(userId, userRepository, threadExecutor, postExecutionThread);`
`52`	`52`	`}`
`53`		`-}`
	`53`	`+}`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@`
`20`	`20`	`import com.fernandocejas.android10.sample.domain.exception.DefaultErrorBundle;`
`21`	`21`	`import com.fernandocejas.android10.sample.domain.exception.ErrorBundle;`
`22`	`22`	`import com.fernandocejas.android10.sample.domain.interactor.DefaultSubscriber;`
	`23`	`+import com.fernandocejas.android10.sample.domain.interactor.GetUserDetails;`
`23`	`24`	`import com.fernandocejas.android10.sample.domain.interactor.UseCase;`
`24`	`25`	`import com.fernandocejas.android10.sample.presentation.exception.ErrorMessageFactory;`
`25`	`26`	`import com.fernandocejas.android10.sample.presentation.internal.di.PerActivity;`
`@@ -43,7 +44,7 @@ public class UserDetailsPresenter implements Presenter {`
`43`	`44`	`private final UserModelDataMapper userModelDataMapper;`
`44`	`45`
`45`	`46`	`@Inject`
`46`		`- public UserDetailsPresenter(@Named("userDetails") UseCase getUserDetailsUseCase,`
	`47`	`+ public UserDetailsPresenter(@Named(GetUserDetails.NAME) UseCase getUserDetailsUseCase,`
`47`	`48`	`UserModelDataMapper userModelDataMapper) {`
`48`	`49`	`this.getUserDetailsUseCase = getUserDetailsUseCase;`
`49`	`50`	`this.userModelDataMapper = userModelDataMapper;`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@`
`20`	`20`	`import com.fernandocejas.android10.sample.domain.exception.DefaultErrorBundle;`
`21`	`21`	`import com.fernandocejas.android10.sample.domain.exception.ErrorBundle;`
`22`	`22`	`import com.fernandocejas.android10.sample.domain.interactor.DefaultSubscriber;`
	`23`	`+import com.fernandocejas.android10.sample.domain.interactor.GetUserList;`
`23`	`24`	`import com.fernandocejas.android10.sample.domain.interactor.UseCase;`
`24`	`25`	`import com.fernandocejas.android10.sample.presentation.exception.ErrorMessageFactory;`
`25`	`26`	`import com.fernandocejas.android10.sample.presentation.internal.di.PerActivity;`
`@@ -44,7 +45,7 @@ public class UserListPresenter implements Presenter {`
`44`	`45`	`private final UserModelDataMapper userModelDataMapper;`
`45`	`46`
`46`	`47`	`@Inject`
`47`		`- public UserListPresenter(@Named("userList") UseCase getUserListUserCase,`
	`48`	`+ public UserListPresenter(@Named(GetUserList.NAME) UseCase getUserListUserCase,`
`48`	`49`	`UserModelDataMapper userModelDataMapper) {`
`49`	`50`	`this.getUserListUseCase = getUserListUserCase;`
`50`	`51`	`this.userModelDataMapper = userModelDataMapper;`

Comments

(0)