Commit 0ece569

committed

Adjust SecondLargestElement solution, add test case

1 parent 14e7bbe commit 0ece569Copy full SHA for 0ece569

File tree

-2

lines changed

src
- main/java/by/andd3dfx/numeric
  - SecondLargestElement.java
- test/java/by/andd3dfx/numeric
  - SecondLargestElementTest.java

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,12 +27,12 @@ public static int find_N(int[] array) {`
`27`	`27`	`int max_2 = Math.min(array[0], array[1]);`
`28`	`28`
`29`	`29`	`for (int i = 2; i < array.length; i++) {`
`30`		`- if (array[i] >= max_1) {`
	`30`	`+ if (array[i] > max_1) {`
`31`	`31`	`max_2 = max_1;`
`32`	`32`	`max_1 = array[i];`
`33`	`33`	`continue;`
`34`	`34`	`}`
`35`		`- if (array[i] >= max_2) {`
	`35`	`+ if (array[i] > max_2) {`
`36`	`36`	`max_2 = array[i];`
`37`	`37`	`}`
`38`	`38`	`}`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,9 @@ public void find_NlogN() {`
`13`	`13`
`14`	`14`	`int[] array2 = {3, 1, 2, 5, 8, 3, 7};`
`15`	`15`	`assertThat(SecondLargestElement.find_NlogN(array2)).isEqualTo(7);`
	`16`	`+`
	`17`	`+ int[] array3 = {3, 1, 2, 5, 8, 3, 7, 8};`
	`18`	`+ assertThat(SecondLargestElement.find_N(array3)).isEqualTo(8);`
`16`	`19`	`}`
`17`	`20`
`18`	`21`	`@Test`
`@@ -22,5 +25,8 @@ public void find_N() {`
`22`	`25`
`23`	`26`	`int[] array2 = {3, 1, 2, 5, 8, 3, 7};`
`24`	`27`	`assertThat(SecondLargestElement.find_N(array2)).isEqualTo(7);`
	`28`	`+`
	`29`	`+ int[] array3 = {3, 1, 2, 5, 8, 3, 7, 8};`
	`30`	`+ assertThat(SecondLargestElement.find_N(array3)).isEqualTo(8);`
`25`	`31`	`}`
`26`	`32`	`}`

Comments

(0)