Commit 1c05026

authored

Merge pull request #100 from amejiarosario/fix/nadhem-findings

fix(bst): on duplicates values the same node is returned

2 parents cec3b04 + d350da8 commit 1c05026Copy full SHA for 1c05026

File tree

-7

lines changed

-7

lines changed

Lines changed: 6 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,23 +19,24 @@ class BinarySearchTree {`
`19`	`19`	`* @returns {BinaryTreeNode} newly added node`
`20`	`20`	`*/`
`21`	`21`	`add(value) {`
`22`		`- constnewNode = new BinaryTreeNode(value);`
	`22`	`+ letnode = new BinaryTreeNode(value);`
`23`	`23`
`24`	`24`	`if (this.root) {`
`25`	`25`	`const { found, parent } = this.findNodeAndParent(value); // <1>`
`26`	`26`	`if (found) { // duplicated: value already exist on the tree`
`27`	`27`	`found.meta.multiplicity = (found.meta.multiplicity \|\| 1) + 1; // <2>`
	`28`	`+ node = found;`
`28`	`29`	`} else if (value < parent.value) {`
`29`		`- parent.setLeftAndUpdateParent(newNode);`
	`30`	`+ parent.setLeftAndUpdateParent(node);`
`30`	`31`	`} else {`
`31`		`- parent.setRightAndUpdateParent(newNode);`
	`32`	`+ parent.setRightAndUpdateParent(node);`
`32`	`33`	`}`
`33`	`34`	`} else {`
`34`		`- this.root = newNode;`
	`35`	`+ this.root = node;`
`35`	`36`	`}`
`36`	`37`
`37`	`38`	`this.size += 1;`
`38`		`- return newNode;`
	`39`	`+ return node;`
`39`	`40`	`}`
`40`	`41`	`// end::add[]`
`41`	`42`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ describe('Binary Search Tree', () => {`
`66`	`66`	`it('should deal with duplicates', () => {`
`67`	`67`	`const root = bst.add(1);`
`68`	`68`	`expect(root.meta.multiplicity).toBe(undefined);`
`69`		`- bst.add(1);`
	`69`	`+ expect(bst.add(1)).toBe(root);// should return existing`
`70`	`70`	`expect(bst.size).toBe(2);`
`71`	`71`	`expect(root.toValues()).toMatchObject({`
`72`	`72`	`value: 1, parent: null, left: null, right: null,`
`@@ -262,7 +262,7 @@ describe('Binary Search Tree', () => {`
`262`	`262`	`});`
`263`	`263`
`264`	`264`	`it('should remove duplicates', () => {`
`265`		`- bst.add(40); // add duplicate`
	`265`	`+ expect(bst.add(40)).toBe(n40); // add duplicate`
`266`	`266`	`expect(n40.meta.multiplicity).toBe(2);`
`267`	`267`
`268`	`268`	`expect(bst.remove(40)).toBe(true);`

Comments

(0)