Commit 88b5dfa

yuuuJacksonTian

authored and

committed

Allow that response.body[Code] is blank.

1 parent d2a5435 commit 88b5dfaCopy full SHA for 88b5dfa

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ def request(action:, params: {}, opts: {})`
`51`	`51`	`end`
`52`	`52`
`53`	`53`	`response_body = JSON.parse(response.body)`
`54`		`- if response_body['Code'] && !self.codes.include?(response_body['Code'])`
	`54`	`+ if response_body['Code'] && !response_body['Code'].to_s.empty? && !self.codes.include?(response_body['Code'])`
`55`	`55`	`raise StandardError, "#{response_body['Message']}, URL: #{uri}"`
`56`	`56`	`end`
`57`	`57`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -167,6 +167,14 @@`
`167`	`167`	`rpc_client.request(action: 'action')`
`168`	`168`	`}.to raise_error(StandardError, /error message, URL:/)`
`169`	`169`	`end`
	`170`	`+`
	`171`	`+ it 'request with no problem should be ok' do`
	`172`	`+ mock_response = { Code: "" }.to_json`
	`173`	`+ stub_request(:get, /https:\/\/ecs.aliyuncs.com/).to_return(status: 200, body: mock_response)`
	`174`	`+ expect {`
	`175`	`+ rpc_client.request(action: 'action')`
	`176`	`+ }.to_not raise_error(StandardError)`
	`177`	`+ end`
`170`	`178`	`end`
`171`	`179`
`172`	`180`	`describe 'RPC private methods' do`

Comments

(0)