Commit 4c370ca

author

jozanini

committed

fix for rate limit response bug

1 parent efe90bb commit 4c370caCopy full SHA for 4c370ca

File tree

+229

-372

lines changed

+229

-372

lines changed

Lines changed: 0 additions & 116 deletions

This file was deleted.

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,11 @@ Contributing Code`
`47`	`47`	`.. code-block:: bash`
`48`	`48`
`49`	`49`	`python3 -m venv venv`
	`50`	`+`
	`51`	`+ # On Mac/Linux`
`50`	`52`	`source venv/bin/activate`
	`53`	`+ # On Windows`
	`54`	`+ venv\Scripts\activate.bat`
`51`	`55`
`52`	`56`	`4. Install poetry.`
`53`	`57`
`@@ -75,7 +79,7 @@ Contributing Code`
`75`	`79`	8. If you running the test suite locally, ensure your code passes all of the default tests. Use the ``test`` target and ensure all tests execute successfully.
`76`	`80`
`77`	`81`	`.. code-block:: bash`
`78`		`-`
	`82`	`+# see below for more information on running the test suite locally`
`79`	`83`	`make tests`
`80`	`84`
`81`	`85`	`9. Commit your changes.`

Lines changed: 17 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -138,12 +138,28 @@ def __init__(self, response):`
`138`	`138`	`assert isinstance(response, requests.Response)`
`139`	`139`
`140`	`140`	`# Extended exception attributes`
`141`		`- self.retry_after = max(1, int(response.headers.get("Retry-After", 15)))`
	`141`	`+ try:`
	`142`	`+ retry_after = int(response.headers.get("Retry-After", 15))`
	`143`	`+ except (ValueError, TypeError):`
	`144`	`+ # Handle malformed Retry-After headers gracefully`
	`145`	`+ # Log a warning for debugging purposes`
	`146`	`+ import logging`
	`147`	`+ logger = logging.getLogger(__name__)`
	`148`	`+ logger.warning(`
	`149`	`+ f"Malformed Retry-After header received: {response.headers.get('Retry-After')}. "`
	`150`	`+ "Defaulting to 15 seconds."`
	`151`	`+ )`
	`152`	`+ retry_after = 15`
	`153`	`+`
	`154`	`+ self.retry_after = max(1, retry_after)`
`142`	`155`	"""The `Retry-After` time period (in seconds) provided by Webex.
`143`	`156`
`144`	`157`	Defaults to 15 seconds if the response `Retry-After` header isn't
`145`	`158`	`present in the response headers, and defaults to a minimum wait time of`
`146`	`159`	1 second if Webex returns a `Retry-After` header of 0 seconds.
	`160`	`+`
	`161`	`+ Note: If the Retry-After header contains malformed values (non-integer strings,`
	`162`	`+ etc.), it will default to 15 seconds and log a warning.`
`147`	`163`	`"""`
`148`	`164`
`149`	`165`	`super(RateLimitError, self).__init__(response)`

Comments

(0)