Commit 5d0aae2

committed

Added wrapper function for factors_recursion() to prevent taking incorrect optional parameters reserved for recursion

Consequently made factors_recursion() private

1 parent ce13b73 commit 5d0aae2Copy full SHA for 5d0aae2

File tree

-3

lines changed

-3

lines changed

Lines changed: 8 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,13 @@ def factors_iteration(number: int, use_while: bool = False) -> list[int]:`
`29`	`29`	`return factors`
`30`	`30`
`31`	`31`	`@staticmethod`
`32`		`- def factors_recursion(number: int, next_factor: Optional[int] = None, factors: Optional[list[int]] = None,`
`33`		`- negative_factors: bool = False) -> list[int]:`
	`32`	`+ def factors_recursion(number: int) -> list[int]:`
	`33`	`+ return Factors.__factors_recursion_implementation(number)`
	`34`	`+`
	`35`	`+ @staticmethod`
	`36`	`+ def __factors_recursion_implementation(number: int, next_factor: Optional[int] = None,`
	`37`	`+ factors: Optional[list[int]] = None,`
	`38`	`+ negative_factors: bool = False) -> list[int]:`
`34`	`39`	`if next_factor is None and factors is None:`
`35`	`40`	`factors = []`
`36`	`41`	`next_factor = abs(number)`
`@@ -46,7 +51,7 @@ def factors_recursion(number: int, next_factor: Optional[int] = None, factors: O`
`46`	`51`	`if negative_factors:`
`47`	`52`	`factors.append(-1 * next_factor)`
`48`	`53`	`factors.append(next_factor)`
`49`		`- return Factors.factors_recursion(number, next_factor - 1, factors, negative_factors)`
	`54`	`+ return Factors.__factors_recursion_implementation(number, next_factor - 1, factors, negative_factors)`
`50`	`55`
`51`	`56`
`52`	`57`	`if __name__ == '__main__':`

Comments

(0)