Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Separate Spring-specific logic from field-declaration-specific logic #2579

Open
Assignees
Labels
comp-codegenIssue is related to code generator comp-springIssue is related to Spring projects support ctg-refactoringIssue related to refactoring process
@IlyaMuravjov

Description

Description

Right now CgSpringVariableConstructor seems to be responsible for both:

  • handling Spring-specific types of models;
  • replacing some variables with fields.

The latter of its responsibilities isn't Spring-specific and I think should be extracted to separate decorator of VariableConstructor.

Potential alternatives

Instead of decorating VariableConstructor we can make its constructor accept VariableConstructorContext and decorate VariableConstructorContext instead, which may be easier given the recursive nature of the VariableConstructor that is hard to combine with decorators.

Metadata

Metadata

Labels

comp-codegenIssue is related to code generator comp-springIssue is related to Spring projects support ctg-refactoringIssue related to refactoring process

Type

No type

Projects

Status

Todo

Milestone

No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      AltStyle によって変換されたページ (->オリジナル) /