Commit 533767f

minh-swinburnetianyizheng02

and

authored

Doomsday Algorithm: Fix leap year check (#12396)

* Fix leap year check Replace `!=` in `(year % 400) != 0` (line 49) with `==` Justification: Years that are divisible by 100 (centurian == 100) but not by 400 (year % 400 != 0) are skipped and NOT leap year. * Update parentheses Correct the parentheses to make clear the precedence of the conditional check * Update other/doomsday.py Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com> --------- Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>

1 parent 0040ad4 commit 533767fCopy full SHA for 533767f

File tree

1 file changed

-1

lines changed

other
- doomsday.py

1 file changed

-1

lines changed

`‎other/doomsday.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ def get_week_day(year: int, month: int, day: int) -> str:`
`46`	`46`	`) % 7`
`47`	`47`	`day_anchor = (`
`48`	`48`	`DOOMSDAY_NOT_LEAP[month - 1]`
`49`		`- if (year % 4 != 0) or (centurian == 0 and (year % 400) == 0)`
	`49`	`+ if year % 4 != 0 or (centurian == 0 and year % 400!= 0)`
`50`	`50`	`else DOOMSDAY_LEAP[month - 1]`
`51`	`51`	`)`
`52`	`52`	`week_day = (dooms_day + day - day_anchor) % 7`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 533767f

File tree

1 file changed

1 file changed

`‎other/doomsday.py`

0 commit comments