Commit 8461271

authored

added check for Integer (#1137)

1 parent b71815d commit 8461271Copy full SHA for 8461271

File tree

+11

-0

lines changed

+11

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,11 @@`
`9`	`9`
`10`	`10`	`function BinaryCountSetBits (a) {`
`11`	`11`	`'use strict'`
	`12`	`+`
	`13`	`+ // check whether input is an integer, some non-integer number like, 21.1 have non-terminating binary expansions and hence their binary expansion will contain infinite ones, thus the handling of non-integers (including strings,objects etc. as it is meaningless) has been omitted`
	`14`	`+`
	`15`	`+ if (!Number.isInteger(a)) throw new TypeError('Argument not an Integer')`
	`16`	`+`
`12`	`17`	`// convert number into binary representation and return number of set bits in binary representation`
`13`	`18`	`return a.toString(2).split('1').length - 1`
`14`	`19`	`}`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,3 +24,9 @@ test('check BinaryCountSetBits of 0 is 0', () => {`
`24`	`24`	`const res = BinaryCountSetBits(0)`
`25`	`25`	`expect(res).toBe(0)`
`26`	`26`	`})`
	`27`	`+test('check BinaryCountSetBits of 21.1 throws error', () => {`
	`28`	`+ expect(() => BinaryCountSetBits(21.1)).toThrow()`
	`29`	`+})`
	`30`	`+test('check BinaryCountSetBits of {} throws error', () => {`
	`31`	`+ expect(() => BinaryCountSetBits({})).toThrow()`
	`32`	`+})`

Comments

(0)