-
Notifications
You must be signed in to change notification settings - Fork 1.3k
avoid padding a struct to be hashed#2024
Open
wsdwsd0829 wants to merge 1 commit intoTextureGroup:master from
Open
avoid padding a struct to be hashed #2024wsdwsd0829 wants to merge 1 commit intoTextureGroup:master from
wsdwsd0829 wants to merge 1 commit intoTextureGroup:master from
Conversation
CLAassistant
commented
Sep 14, 2021
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Contributor
rcancro
commented
Sep 17, 2021
Let's try these things and see if they work:
- Try setting the values of the struct explicitly like the comment in
ASHashBytessuggests - Try changing the type of
ASScrollDirectionfromunsigned chartoNSUInteger
If neither of those work, let's land this! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternatively
{
#pragma pack(push,1)
struct {
CGSize viewportSize;
ASScrollDirection scrollableDirections;
NSUInteger elementsHash;
NSUInteger layoutDelegateClassHash;
NSUInteger additionalInfoHash;
} data = {
_viewportSize,
_scrollableDirections,
_elements.hash,
_layoutDelegateClass.hash,
[_additionalInfo hash]
};
#pragma pack(pop)
return ASHashBytes(&data, sizeof(data));
}
I am less confident about what #pragma pack(push,1) is doing