Commit c945c6d

committed

fix(react-sortable.jsx): const newList = [...props.list].map((item) =>

); there is copy issue

1 parent 54d778c commit c945c6dCopy full SHA for c945c6d

File tree

1 file changed

-7

lines changed

src
- react-sortable.tsx

1 file changed

-7

lines changed

`‎src/react-sortable.tsx`

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ export class ReactSortable<T extends ItemInterface> extends Component<`
`50`	`50`
`51`	`51`	`// make all state false because we can't change sortable unless a mouse gesture is made.`
`52`	`52`	`const newList = [...props.list].map((item) =>`
`53`		`- Object.assign(item, {`
	`53`	`+ Object.assign({},item, {`
`54`	`54`	`chosen: false,`
`55`	`55`	`selected: false,`
`56`	`56`	`})`
`@@ -238,7 +238,7 @@ Please read the updated README.md at https://github.com/SortableJS/react-sortabl`
`238`	`238`	`removeNodes(customs);`
`239`	`239`
`240`	`240`	`const newList = handleStateAdd(customs, list, evt, clone).map((item) =>`
`241`		`- Object.assign(item, {`
	`241`	`+ Object.assign({},item, {`
`242`	`242`	`selected: false,`
`243`	`243`	`})`
`244`	`244`	`);`
`@@ -294,7 +294,7 @@ Please read the updated README.md at https://github.com/SortableJS/react-sortabl`
`294`	`294`
`295`	`295`	`// remove item.selected from list`
`296`	`296`	`newList = newList.map((item: T) =>`
`297`		`- Object.assign(item, {`
	`297`	`+ Object.assign({},item, {`
`298`	`298`	`selected: false,`
`299`	`299`	`})`
`300`	`300`	`);`
`@@ -324,7 +324,7 @@ Please read the updated README.md at https://github.com/SortableJS/react-sortabl`
`324`	`324`	`const newList = list.map((item, index) => {`
`325`	`325`	`let newItem = item;`
`326`	`326`	`if (index === evt.oldIndex) {`
`327`		`- newItem = Object.assign(item, {`
	`327`	`+ newItem = Object.assign({},item, {`
`328`	`328`	`chosen: true,`
`329`	`329`	`});`
`330`	`330`	`}`
`@@ -338,7 +338,7 @@ Please read the updated README.md at https://github.com/SortableJS/react-sortabl`
`338`	`338`	`const newList = list.map((item, index) => {`
`339`	`339`	`let newItem = item;`
`340`	`340`	`if (index === evt.oldIndex) {`
`341`		`- newItem = Object.assign(newItem, {`
	`341`	`+ newItem = Object.assign({},newItem, {`
`342`	`342`	`chosen: false,`
`343`	`343`	`});`
`344`	`344`	`}`
`@@ -355,7 +355,7 @@ Please read the updated README.md at https://github.com/SortableJS/react-sortabl`
`355`	`355`	`onSelect(evt: MultiDragEvent): void {`
`356`	`356`	`const { list, setList } = this.props;`
`357`	`357`	`const newList = list.map((item) =>`
`358`		`- Object.assign(item, {`
	`358`	`+ Object.assign({},item, {`
`359`	`359`	`selected: false,`
`360`	`360`	`})`
`361`	`361`	`);`
`@@ -377,7 +377,7 @@ Please read the updated README.md at https://github.com/SortableJS/react-sortabl`
`377`	`377`	`onDeselect(evt: MultiDragEvent): void {`
`378`	`378`	`const { list, setList } = this.props;`
`379`	`379`	`const newList = list.map((item) =>`
`380`		`- Object.assign(item, {`
	`380`	`+ Object.assign({},item, {`
`381`	`381`	`selected: false,`
`382`	`382`	`})`
`383`	`383`	`);`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit c945c6d

File tree

1 file changed

1 file changed

`‎src/react-sortable.tsx`

0 commit comments