Commit 5ff3f4a

authored

fix: passes clone function to onAdd if cloning (#173)

* onAdd method can add new attribution when cloning; BUG FIXED: clone the DOM at first time add new attribution invalid

1 parent 096c276 commit 5ff3f4aCopy full SHA for 5ff3f4a

File tree

+10

-5

lines changed

+10

-5

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -216,11 +216,11 @@ Please read the updated README.md at https://github.com/SortableJS/react-sortabl`
`216`	`216`	`// SORTABLE DOM HANDLING`
`217`	`217`
`218`	`218`	`onAdd(evt: MultiDragEvent) {`
`219`		`- const { list, setList } = this.props;`
	`219`	`+ const { list, setList, clone } = this.props;`
`220`	`220`	`const otherList = [...store.dragging!.props.list];`
`221`	`221`	`const customs = createCustoms(evt, otherList);`
`222`	`222`	`removeNodes(customs);`
`223`		`- const newList = handleStateAdd(customs, list);`
	`223`	`+ const newList = handleStateAdd(customs, list,evt,clone).map(item=>({ ...item,selected: false}));`
`224`	`224`	`setList(newList, this.sortable, store);`
`225`	`225`	`}`
`226`	`226`

Lines changed: 8 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`import { PropsWithChildren } from "react";`
`2`		`-import { Options } from "sortablejs";`
	`2`	`+import Sortable,{ Options } from "sortablejs";`
`3`	`3`	`import { MultiDragEvent } from "./react-sortable";`
`4`	`4`	`import { AllMethodNames, ItemInterface, ReactSortableProps } from "./types";`
`5`	`5`
`@@ -116,10 +116,15 @@ export function handleStateRemove<T extends ItemInterface>(`
`116`	`116`
`117`	`117`	`export function handleStateAdd<T extends ItemInterface>(`
`118`	`118`	`normalized: Normalized<T>[],`
`119`		`- list: T[]`
	`119`	`+ list: T[],`
	`120`	`+ evt?: Sortable.SortableEvent,`
	`121`	`+ clone?: ((currentItem: T, evt: Sortable.SortableEvent) => T) \| undefined`
`120`	`122`	`): T[] {`
`121`	`123`	`const newList = [...list];`
`122`		`- normalized.forEach(curr => newList.splice(curr.newIndex, 0, curr.item));`
	`124`	`+ normalized.forEach(curr => {`
	`125`	`+ const newItem = (clone && evt) && clone(curr.item, evt);`
	`126`	`+ newList.splice(curr.newIndex, 0, newItem \|\| curr.item)`
	`127`	`+ });`
`123`	`128`	`return newList;`
`124`	`129`	`}`
`125`	`130`

Comments

(0)