Commit bd15ca9

author

Matt Fehskens

committed

Added correct name of remove handler method

- Added test for checking that a handler was added

1 parent 8dd14f3 commit bd15ca9Copy full SHA for bd15ca9

File tree

+17

-2

lines changed

+17

-2

lines changed

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -164,5 +164,20 @@ describe('<Plotly/>', () => {`
`164`	`164`	`.catch(err => done.fail(err));`
`165`	`165`	`});`
`166`	`166`	`});`
	`167`	`+`
	`168`	`+ describe('manging event handlers', () => {`
	`169`	`+ test('should add an event handler when one does not already exist', (done) => {`
	`170`	`+ const onRelayout = () => {};`
	`171`	`+`
	`172`	`+ createPlot({onRelayout}).then((plot) => {`
	`173`	`+ const { handlers } = plot.instance();`
	`174`	`+`
	`175`	`+ expect(plot.prop('onRelayout')).toBe(onRelayout);`
	`176`	`+ expect(handlers.Relayout).toBe(onRelayout);`
	`177`	`+`
	`178`	`+ done();`
	`179`	`+ });`
	`180`	`+ });`
	`181`	`+ });`
`167`	`182`	`});`
`168`	`183`	`});`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -214,10 +214,10 @@ export default function plotComponentFactory(Plotly) {`
`214`	`214`	`this.addEventHandler(eventName, prop);`
`215`	`215`	`} else if (!prop && hasHandler) {`
`216`	`216`	`// Needs to be removed:`
`217`		`- this.removeHandler(eventName);`
	`217`	`+ this.removeEventHandler(eventName);`
`218`	`218`	`} else if (prop && hasHandler && prop !== handler) {`
`219`	`219`	`// replace the handler`
`220`		`- this.removeHandler(eventName);`
	`220`	`+ this.removeEventHandler(eventName);`
`221`	`221`	`this.addEventHandler(eventName, prop);`
`222`	`222`	`}`
`223`	`223`	`});`

Comments

(0)