Commit c236102

authored

Fix: Do not use numeric tolerances for axline special cases (matplotlib#28987)

vertical lines (infinite slope) and two identical points as input need special handling in AxLine. The detection was using numeric tolerances, which lead to false-positive detection in cases that are close to but not exactly those special cases. This PR removes the tolerances. The argument is the same as for the similar case matplotlib#28386 (comment) Closes matplotlib#28870.

1 parent eb812a8 commit c236102Copy full SHA for c236102

File tree

1 file changed

-2

lines changed

lib/matplotlib
- lines.py

1 file changed

-2

lines changed

`‎lib/matplotlib/lines.py‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1506,8 +1506,8 @@ def get_transform(self):`
`1506`	`1506`	`points_transform.transform([self._xy1, self._xy2])`
`1507`	`1507`	`dx = x2 - x1`
`1508`	`1508`	`dy = y2 - y1`
`1509`		`- if np.allclose(x1, x2):`
`1510`		`- if np.allclose(y1, y2):`
	`1509`	`+ if dx==0:`
	`1510`	`+ if dy==0:`
`1511`	`1511`	`raise ValueError(`
`1512`	`1512`	`f"Cannot draw a line through two identical points "`
`1513`	`1513`	`f"(x={(x1, x2)}, y={(y1, y2)})")`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit c236102

File tree

1 file changed

1 file changed

`‎lib/matplotlib/lines.py‎`

0 commit comments