Commit 06c73f9

authored

Merge pull request matplotlib#29531 from meeseeksmachine/auto-backport-of-pr-29520-on-v3.10.x

Backport PR matplotlib#29520 on branch v3.10.x (FIX: Correct variable name from _frame to _frames in PillowWriter class)

2 parents 90ae776 + 11df011 commit 06c73f9Copy full SHA for 06c73f9

File tree

+19

-1

lines changed

+19

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -496,7 +496,7 @@ def grab_frame(self, **savefig_kwargs):`
`496`	`496`	`"RGBA", self.frame_size, buf.getbuffer(), "raw", "RGBA", 0, 1)`
`497`	`497`	`if im.getextrema()[3][0] < 255:`
`498`	`498`	`# This frame has transparency, so we'll just add it as is.`
`499`		`- self._frame.append(im)`
	`499`	`+ self._frames.append(im)`
`500`	`500`	`else:`
`501`	`501`	`# Without transparency, we switch to RGB mode, which converts to P mode a`
`502`	`502`	`# little better if needed (specifically, this helps with GIF output.)`

Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`	`import matplotlib as mpl`
`14`	`14`	`from matplotlib import pyplot as plt`
`15`	`15`	`from matplotlib import animation`
	`16`	`+from matplotlib.animation import PillowWriter`
`16`	`17`	`from matplotlib.testing.decorators import check_figures_equal`
`17`	`18`
`18`	`19`
`@@ -551,3 +552,20 @@ def test_movie_writer_invalid_path(anim):`
`551`	`552`	`with pytest.raises(FileNotFoundError, match=match_str):`
`552`	`553`	`anim.save("/foo/bar/aardvark/thiscannotreallyexist.mp4",`
`553`	`554`	`writer=animation.FFMpegFileWriter())`
	`555`	`+`
	`556`	`+`
	`557`	`+def test_animation_with_transparency():`
	`558`	`+ """Test animation exhaustion with transparency using PillowWriter directly"""`
	`559`	`+ fig, ax = plt.subplots()`
	`560`	`+ rect = plt.Rectangle((0, 0), 1, 1, color='red', alpha=0.5)`
	`561`	`+ ax.add_patch(rect)`
	`562`	`+ ax.set_xlim(0, 1)`
	`563`	`+ ax.set_ylim(0, 1)`
	`564`	`+`
	`565`	`+ writer = PillowWriter(fps=30)`
	`566`	`+ writer.setup(fig, 'unused.gif', dpi=100)`
	`567`	`+ writer.grab_frame(transparent=True)`
	`568`	`+ frame = writer._frames[-1]`
	`569`	`+ # Check that the alpha channel is not 255, so frame has transparency`
	`570`	`+ assert frame.getextrema()[3][0] < 255`
	`571`	`+ plt.close(fig)`

Comments

(0)