Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 05af5f8

Browse files
Merge pull request #41 from PracticeJavaScript/issues
added issues link, tiny layout tweaks
2 parents 1a6b2a9 + 8804c20 commit 05af5f8

File tree

6 files changed

+48
-17
lines changed

6 files changed

+48
-17
lines changed

‎.codeclimate.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
engines:
2+
csslint:
3+
enabled: true
4+
exclude_paths:
5+
- public/**/*
6+
- src/js/loadJS.js

‎.editorconfig

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# This file is for unifying the coding style for different editors and IDEs
2+
# editorconfig.org
3+
4+
root = true
5+
6+
[*]
7+
charset = utf-8
8+
trim_trailing_whitespace = true
9+
insert_final_newline = true
10+
indent_style = space
11+
indent_size = 2

‎public/dist/css/style.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎public/dist/js/bundle.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎public/index.html

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,14 @@
44
<title>Practice JavaScript</title>
55
<meta charset="UTF-8">
66
<meta name="viewport" content="width=device-width, initial-scale=1">
7-
<link href="./dist/css/style.css" rel="stylesheet">
87
</head>
98
<body>
9+
<style>
10+
body {
11+
opacity: 0;
12+
transition: opacity 200ms ease-in-out;
13+
}
14+
</style>
1015
<heading class="site-heading">
1116
<div class="container">
1217
<span>
@@ -29,6 +34,7 @@ <h1>Practice JavaScript!</h1>
2934
</nav>
3035
</div>
3136
</heading>
37+
3238
<div class="container">
3339
<main>
3440
<div class="problem-group">
@@ -47,7 +53,7 @@ <h4>TEST ERRORS</h4>
4753
</div>
4854
</div>
4955
<div class="code-and-eval-console">
50-
<textarea id="code" class="code monospace" rows="15" autofocus autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false"></textarea>
56+
<textarea id="code" class="code monospace" rows="10" autofocus autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false"></textarea>
5157
<div id="eval-console" class="eval-console console monospace">
5258
<h4>CODE OUTPUT</h4>
5359
<div id="eval-output"></div>
@@ -56,17 +62,22 @@ <h4>CODE OUTPUT</h4>
5662
</div>
5763
</main>
5864
</div>
65+
5966
<!-- practice-javascript-bottom-banner -->
6067
<div class="ads-bottom">
6168
<ins class="adsbygoogle"
6269
style="display:inline-block;width:728px;height:90px"
6370
data-ad-client="ca-pub-4039212144643368"
6471
data-ad-slot="9721927778"></ins>
6572
</div>
73+
6674
<footer>
6775
<div class="copyright">© 2017 <a href="https://twitter.com/jakob_anderson">Jakob Anderson</a></div>
76+
<div class="issues"><a href="https://github.com/PracticeJavaScript/practicejavascript.com/issues">Problems? Leave an issue on github</a></div>
6877
<div class="icon-license">Icons designed by <a href="http://www.flaticon.com/authors/gregor-cresnar">Gregor Cresnar</a> from Flaticon</div>
6978
</footer>
79+
80+
<link href="./dist/css/style.css" rel="stylesheet">
7081
<script src="./dist/js/bundle.min.js"></script>
7182
<script src="./dist/js/loadJS.js"></script>
7283

‎src/css/style.scss

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@
55
@import 'lib/mixins';
66
@import 'lib/defaults';
77

8+
/* show body once css has loaded */
9+
body {
10+
opacity: 1;
11+
transition: opacity 200ms ease-in-out;
12+
}
813

914
/* grid elements */
1015
.container {
@@ -51,7 +56,7 @@
5156
padding: 1em;
5257
border-radius: 1em;
5358
background-color: transparent;
54-
height: 60px;
59+
height: 30px;
5560
}
5661
.controls > div > :active,
5762
.controls > div > .active {
@@ -76,10 +81,12 @@
7681
.code {
7782
font-size: 80%;
7883
color: #f8f8f2;
84+
color: #fff;
7985
overflow-x: auto;
8086
padding: .5em;
81-
// background: #23241f;
82-
background-color: $primary-text-color;
87+
background: #23241f;
88+
background: #1a1a1a;
89+
// background-color: $primary-text-color;
8390
border-radius: 3px;
8491
padding: .25em .65em;
8592
display: inline-block;
@@ -157,20 +164,16 @@
157164
margin: 5em 0 1em;
158165
}
159166
footer {
160-
// width: 85%;
161167
margin: 0 auto;
162168
text-align: center;
163-
position:fixed;
164169
left:0px;
165170
bottom:0px;
166171
height:70px;
167172
width:100%;
173+
font-size: 60%;
168174
}
169175
footer > div {
170-
margin: 10px auto;
171-
}
172-
.icon-license {
173-
font-size: 50%;
176+
margin: 0.4em auto;
174177
}
175178

176179
/* Because we are mobile-first, here is css for bigger than mobile */
@@ -195,12 +198,12 @@ footer > div {
195198
font-size: 200%;
196199
}
197200
.site-heading img.logo {
198-
height: 70px;
199-
display: flex;
200-
}
201-
.controls img {
202201
height: 60px;
202+
display: flex;
203203
}
204+
// .controls img {
205+
// height: 30px;
206+
// }
204207

205208
.problem-name {
206209
display: block;

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /