Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Unfortunate color choices with semantic highlighting #2856

Closed
@mattpwhite

Description

(this is in reference to the PowerShell Preview extension 202070)

I understand that there are some limitations around the mapping PS token types to the (smaller) set of types the VS Code API allows and that this requires some compromises. That said, I'm particularly bothered by the way things are colored with the default VS Code theme. I don't mean which colors are chosen (that's obviously personal taste), I mean places where token types that are frequently adjacent to each other are given the same color. The point of giving things colors is to provide contrast, that's not happening in a number of common cases.

  1. Parameter names and variables are the same color.

image

  1. Attributes and types are the same color. This makes complex parameter declarations a bit harder to read. It also makes attributes that have a type as an argument a bit worse.

image

image

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /