Commit a8b28e0

o-l-a-vandyleejordan

and

authored

Fix #5086 - Invalid JSON in the snippets file (#5087)

* Fixed JSON * Added test for making sure all JSON files are valid JSON * Run in correct dir * Simplify title of the new step Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com> * Fix path double nesting Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com> * Add spaces after commas Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com> * Use $PWD instead of '.\' for current dir 🐧 * Only test the snippets JSON file * Oops, typo --------- Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>

1 parent 18b7263 commit a8b28e0Copy full SHA for a8b28e0

File tree

2 files changed

+25

-21

lines changed

.github/workflows
- ci-test.yml
snippets
- PowerShell.json

2 files changed

+25

-21

lines changed

`‎.github/workflows/ci-test.yml‎`

Lines changed: 9 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,19 +2,19 @@ name: CI Tests`
`2`	`2`
`3`	`3`	`on:`
`4`	`4`	`push:`
`5`		`- branches: [main]`
	`5`	`+ branches: [main]`
`6`	`6`	`pull_request:`
`7`	`7`	`# The branches below must be a subset of the branches above`
`8`		`- branches: [main]`
	`8`	`+ branches: [main]`
`9`	`9`	`merge_group:`
`10`		`- types: [checks_requested]`
	`10`	`+ types: [checks_requested]`
`11`	`11`
`12`	`12`	`jobs:`
`13`	`13`	`ci:`
`14`	`14`	`name: node`
`15`	`15`	`strategy:`
`16`	`16`	`matrix:`
`17`		`- os: [windows-latest, macos-latest, ubuntu-latest]`
	`17`	`+ os: [windows-latest, macos-latest, ubuntu-latest]`
`18`	`18`	`runs-on: ${{ matrix.os }}`
`19`	`19`	`env:`
`20`	`20`	`DOTNET_NOLOGO: true`
`@@ -33,6 +33,11 @@ jobs:`
`33`	`33`	`with:`
`34`	`34`	`path: vscode-powershell`
`35`	`35`
	`36`	`+ - name: Validate snippets JSON file`
	`37`	`+ shell: pwsh`
	`38`	`+ run: $null = ConvertFrom-Json -InputObject (Get-Content -Raw -Path './snippets/PowerShell.json')`
	`39`	`+ working-directory: vscode-powershell`
	`40`	`+`
`36`	`41`	`- name: Install dotnet`
`37`	`42`	`uses: actions/setup-dotnet@v4`
`38`	`43`	`with:`

`‎snippets/PowerShell.json‎`

Lines changed: 16 additions & 17 deletions

Original file line number	Diff line number	Diff line change
`@@ -162,24 +162,23 @@`
`162`	`162`	`]`
`163`	`163`	`},`
`164`	`164`	`"Foreach with Progress": {`
`165`		`-"prefix": "foreach-progress",`
	`165`	`+"prefix": "foreach-progress",`
`166`	`166`	`"description": "Insert a foreach loop with Write-Progress initialized",`
`167`		`- "body": [`
`168`		`-\\$progPercent = \"{0:n2}\" -f ([math]::round(\\$i/\\$array.count,4) * 100)",`
`169`		`-`
`170`		`-Write-Progress -Activity \"${3:activityName}\" -Status \"\\$i of \\$array.count - \\$progPercent% Complete:\" -PercentComplete \\$progPercent",`
`171`		`- "\\$i = 1",`
`172`		`- "foreach ($${2:item} in $${1:array}) {",`
`173`		`- " \\$progPercent = \"{0:n2}\" -f ([math]::round(\\$i/\\$total,4) * 100)",`
`174`		`- " Write-Progress -Activity \"${3:activityName}\" -Status \"\\$i of \\$total - \\$progPercent% Complete:\" -PercentComplete \\$progPercent",`
`175`		`- " # Insert Code Here",`
`176`		`- " ${0}",`
`177`		`- " ",`
`178`		`- " \\$i++",`
`179`		`- "}",`
`180`		`- ""`
`181`		`- ]`
`182`		`- },`
	`167`	`+ "body": [`
	`168`	`+ "\\$progPercent = \"{0:n2}\" -f ([math]::round(\\$i/\\$array.count,4) * 100)",`
	`169`	`+ "Write-Progress -Activity \"${3:activityName}\" -Status \"\\$i of \\$array.count - \\$progPercent% Complete:\" -PercentComplete \\$progPercent",`
	`170`	`+ "\\$i = 1",`
	`171`	`+ "foreach ($${2:item} in $${1:array}) {",`
	`172`	`+ " \\$progPercent = \"{0:n2}\" -f ([math]::round(\\$i/\\$total,4) * 100)",`
	`173`	`+ " Write-Progress -Activity \"${3:activityName}\" -Status \"\\$i of \\$total - \\$progPercent% Complete:\" -PercentComplete \\$progPercent",`
	`174`	`+ " # Insert Code Here",`
	`175`	`+ " ${0}",`
	`176`	`+ " ",`
	`177`	`+ " \\$i++",`
	`178`	`+ "}",`
	`179`	`+ ""`
	`180`	`+ ]`
	`181`	`+ },`
`183`	`182`	`"ForEach-Object -Parallel": {`
`184`	`183`	`"prefix": "foreach-parallel",`
`185`	`184`	`"description": "[PS 7+] Process multiple objects in parallel using runspaces. This has some limitations compared to a regular ForEach-Object. More: Get-Help ForEach-Object",`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit a8b28e0

File tree

2 files changed

2 files changed

`‎.github/workflows/ci-test.yml‎`

`‎snippets/PowerShell.json‎`

0 commit comments