Commit 5156173

committed

(maint) Modify tslint configuration for test files

Previously tslint was raising errors in Travis CI saying that the excluded test fixtures directory was not included in the project. This was by design however it appears to be a known bug palantir/tslint#3793. This commit removes the exclude for test files from linting and adds a tslint directive in the default index.ts file. A tslint directive is used instead of solving the issue because this is the default testing file for VS Code extesions and shouldn't really be modified unless absolutely necessary. In this instance it was safer for a tslint directive.

1 parent 0434ff8 commit 5156173Copy full SHA for 5156173

File tree

2 files changed

-1

lines changed

package.json
test
- index.ts

2 files changed

-1

lines changed

`‎package.json‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@`
`52`	`52`	`"vscode.powershell"`
`53`	`53`	`],`
`54`	`54`	`"scripts": {`
`55`		`- "compile": "tsc -v && tsc -p ./ && tslint -p ./ -e test/*",`
	`55`	`+ "compile": "tsc -v && tsc -p ./ && tslint -p ./",`
`56`	`56`	`"compile-watch": "tsc -watch -p ./",`
`57`	`57`	`"postinstall": "node ./node_modules/vscode/bin/install",`
`58`	`58`	`"test": "node ./node_modules/vscode/bin/test"`

`‎test/index.ts‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// tslint:disable no-var-requires`
`1`	`2`	`let testRunner = require("vscode/lib/testrunner");`
`2`	`3`
`3`	`4`	`// See https://github.com/mochajs/mocha/wiki/Using-mocha-programmatically#set-options for options`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 5156173

File tree

2 files changed

2 files changed

`‎package.json‎`

`‎test/index.ts‎`

0 commit comments