Commit 2384b7c

authored

Fix EnableISEMode for Azure Data Studio (#3735)

Because ADS stripped out VS Code's debugger, the `debug` settings don't exist, causing our `update()` call for the debug setting to throw an error to the user when they run `EnableISEMode`. I couldn't find a reliable way to test if the extension is running in the ADS fork instead of the upstream VS Code, but a simple `try {} catch {}` that allows the funciton to continue is a reliable fix, as we can't do anything about this setting regardless.

1 parent 43cf7d1 commit 2384b7cCopy full SHA for 2384b7c

File tree

1 file changed

-1

lines changed

src/features
- ISECompatibility.ts

1 file changed

-1

lines changed

`‎src/features/ISECompatibility.ts‎`

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,15 @@ export class ISECompatibilityFeature implements vscode.Disposable {`
`42`	`42`
`43`	`43`	`private async EnableISEMode() {`
`44`	`44`	`for (const iseSetting of ISECompatibilityFeature.settings) {`
`45`		`- await vscode.workspace.getConfiguration(iseSetting.path).update(iseSetting.name, iseSetting.value, true);`
	`45`	`+ try {`
	`46`	`+ await vscode.workspace.getConfiguration(iseSetting.path).update(iseSetting.name, iseSetting.value, true);`
	`47`	`+ } catch {`
	`48`	+ // The `update` call can fail if the setting doesn't exist. This
	`49`	`+ // happens when the extension runs in Azure Data Studio, which`
	`50`	+ // doesn't have a debugger, so the `debug` setting can't be
	`51`	`+ // updated. Unless we catch this exception and allow the`
	`52`	`+ // function to continue, it throws an error to the user.`
	`53`	`+ }`
`46`	`54`	`}`
`47`	`55`
`48`	`56`	`// Show the PowerShell Command Explorer`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 2384b7c

File tree

1 file changed

1 file changed

`‎src/features/ISECompatibility.ts‎`

0 commit comments