Commit 160a903

JustinGroteandyleejordan

authored and

committed

Some more logging Levels and cleanup

1 parent b585308 commit 160a903Copy full SHA for 160a903

File tree

2 files changed

-11

lines changed

src/PowerShellEditorServices.Hosting
- Configuration
  - HostLogger.cs
- EditorServicesLoader.cs

2 files changed

-11

lines changed

`‎src/PowerShellEditorServices.Hosting/Configuration/HostLogger.cs‎`

Lines changed: 3 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -229,25 +229,23 @@ public void OnNext((PsesLogLevel logLevel, string message) value)`
`229`	`229`	`switch (logLevel)`
`230`	`230`	`{`
`231`	`231`	`case PsesLogLevel.Trace:`
	`232`	`+ ui.WriteDebugLine("[Trace] " + message);`
	`233`	`+ break;`
`232`	`234`	`case PsesLogLevel.Debug:`
`233`	`235`	`ui.WriteDebugLine(message);`
`234`	`236`	`break;`
`235`		`-`
`236`	`237`	`case PsesLogLevel.Information:`
`237`	`238`	`ui.WriteVerboseLine(message);`
`238`	`239`	`break;`
`239`		`-`
`240`	`240`	`case PsesLogLevel.Warning:`
`241`	`241`	`ui.WriteWarningLine(message);`
`242`	`242`	`break;`
`243`		`-`
`244`	`243`	`case PsesLogLevel.Error:`
`245`	`244`	`case PsesLogLevel.Critical:`
`246`	`245`	`ui.WriteErrorLine(message);`
`247`	`246`	`break;`
`248`		`-`
`249`	`247`	`default:`
`250`		`- ui.WriteLine(message);`
	`248`	`+ ui.WriteDebugLine("UNKNOWN:"+message);`
`251`	`249`	`break;`
`252`	`250`	`}`
`253`	`251`	`}`

`‎src/PowerShellEditorServices.Hosting/EditorServicesLoader.cs‎`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -212,10 +212,10 @@ public Task LoadAndRunEditorServicesAsync()`
`212`	`212`	`ValidateConfiguration();`
`213`	`213`
`214`	`214`	`// Method with no implementation that forces the PSES assembly to load, triggering an AssemblyResolve event`
`215`		`- _logger.Log(PsesLogLevel.Information, "Loading PowerShell Editor Services");`
	`215`	`+ _logger.Log(PsesLogLevel.Information, "Loading PowerShell Editor Services Assemblies");`
`216`	`216`	`LoadEditorServices();`
`217`	`217`
`218`		`- _logger.Log(PsesLogLevel.Information, "Starting EditorServices");`
	`218`	`+ _logger.Log(PsesLogLevel.Information, "Starting PowerShell Editor Services");`
`219`	`219`
`220`	`220`	`_editorServicesRunner = new EditorServicesRunner(_logger, _hostConfig, _sessionFileWriter, _loggersToUnsubscribe);`
`221`	`221`
`@@ -242,7 +242,7 @@ private void CheckPowerShellVersion()`
`242`	`242`	`{`
`243`	`243`	`PSLanguageMode languageMode = Runspace.DefaultRunspace.SessionStateProxy.LanguageMode;`
`244`	`244`
`245`		`- _logger.Log(PsesLogLevel.Debug, $@"`
	`245`	`+ _logger.Log(PsesLogLevel.Trace, $@"`
`246`	`246`	`== PowerShell Details ==`
`247`	`247`	`- PowerShell version: {_powerShellVersion}`
`248`	`248`	`- Language mode: {languageMode}`
`@@ -295,12 +295,12 @@ private void UpdatePSModulePath()`
`295`	`295`	`}`
`296`	`296`	`psModulePath = $"{psModulePath}{Path.PathSeparator}{_hostConfig.BundledModulePath}";`
`297`	`297`	`Environment.SetEnvironmentVariable("PSModulePath", psModulePath);`
`298`		`- _logger.Log(PsesLogLevel.Debug, $"Updated PSModulePath to: '{psModulePath}'");`
	`298`	`+ _logger.Log(PsesLogLevel.Trace, $"Updated PSModulePath to: '{psModulePath}'");`
`299`	`299`	`}`
`300`	`300`
`301`	`301`	`private void LogHostInformation()`
`302`	`302`	`{`
`303`		`- _logger.Log(PsesLogLevel.Debug, $"PID: {System.Diagnostics.Process.GetCurrentProcess().Id}");`
	`303`	`+ _logger.Log(PsesLogLevel.Trace, $"PID: {System.Diagnostics.Process.GetCurrentProcess().Id}");`
`304`	`304`
`305`	`305`	`_logger.Log(PsesLogLevel.Debug, $@"`
`306`	`306`	`== Build Details ==`
`@@ -359,7 +359,7 @@ private static string GetPSOutputEncoding()`
`359`	`359`	`[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2208:Instantiate argument exceptions correctly", Justification = "Checking user-defined configuration")]`
`360`	`360`	`private void ValidateConfiguration()`
`361`	`361`	`{`
`362`		`- _logger.Log(PsesLogLevel.Trace, "Validating configuration");`
	`362`	`+ _logger.Log(PsesLogLevel.Debug, "Validating configuration");`
`363`	`363`
`364`	`364`	`bool lspUsesStdio = _hostConfig.LanguageServiceTransport is StdioTransportConfig;`
`365`	`365`	`bool debugUsesStdio = _hostConfig.DebugServiceTransport is StdioTransportConfig;`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 160a903

File tree

2 files changed

2 files changed

`‎src/PowerShellEditorServices.Hosting/Configuration/HostLogger.cs‎`

`‎src/PowerShellEditorServices.Hosting/EditorServicesLoader.cs‎`

0 commit comments