-
Notifications
You must be signed in to change notification settings - Fork 250
build: Update rust toolchain version #5673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
max-sixty
commented
Jan 23, 2026
@claude please fix
Fixing Rust 1.92 Clippy False Positives
- Gather context and understand the issue
- Identify root cause: Rust 1.92 unused_assignments bug
- Apply
#![allow(unused_assignments)]at crate level to fix all affected enums - Run tests to verify the fix (637 tests passed ✓)
- Push changes
- Fix additional CI issue: unused import + formatting in test file
- Verify CI passes
Changes:
- Added
#![allow(unused_assignments)]at the crate level inprqlc/prqlc/src/lib.rsto suppress false positive warnings from theenum-as-innerderive macro (rust-lang/rust#147648) - Removed unused
envimport fromprqlc/prqlc/tests/integration/queries.rsand fixed import ordering
Commits:
Add #![allow(unused_assignments)] at crate level to suppress false positive warnings introduced by Rust 1.92's stricter lint behavior on code generated by the enum-as-inner derive macro. This is a known Rust compiler bug tracked at: - rust-lang/rust#147648 The fix for enum-as-inner is pending at: - bluejekyll/enum-as-inner#108 The allow can be removed once enum-as-inner is updated. Co-Authored-By: Maximilian Roos <max-sixty@users.noreply.github.com>
Rust 1.92's stricter linting caught this unused import. Co-Authored-By: Maximilian Roos <max-sixty@users.noreply.github.com>
@claude
claude
bot
force-pushed
the
update_rust_toolchain_action
branch
from
January 23, 2026 17:04
2b577db to
d2b6c34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic change by the update-rust-toolchain Github Action.
Github Actions will not run workflows on pull requests which are opened by a GitHub Action.
For examples on how to run workflows on this pr, please go to the readme.