Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: make GitHub query limits configurable via env#167

Merged
O2sa merged 1 commit into
O2sa:main from
ShashwatUpadhayay:feat/configurable-github-query-limits-v2
Jun 24, 2026
Merged

feat: make GitHub query limits configurable via env #167
O2sa merged 1 commit into
O2sa:main from
ShashwatUpadhayay:feat/configurable-github-query-limits-v2

Conversation

@ShashwatUpadhayay

@ShashwatUpadhayay ShashwatUpadhayay commented Jun 23, 2026
edited by O2sa
Loading

Copy link
Copy Markdown
Contributor

Make GitHub query limits configurable through environment variables:

  • GITHUB_REPO_COUNT
  • GITHUB_PR_COUNT
  • GITHUB_ISSUE_COUNT
  • GITHUB_DISCUSSION_COUNT
  • Add parsing and validation with sensible defaults and upper bounds
  • Replace hardcoded query limits with runtime configuration
  • Document the new environment variables
  • Add unit tests for parsing and validation logic

Testing

  • Verified default values are used when environment variables are missing or invalid
  • Verified valid values are parsed correctly
  • Verified oversized values are clamped to the configured maximum
  • Ran the test suite successfully

Close #160

github-actions[bot] reacted with eyes emoji

vercel Bot commented Jun 23, 2026

Copy link
Copy Markdown

@ShashwatUpadhayay is attempting to deploy a commit to the osama's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown

Thank you for the pull request! ✅

A maintainer will review this soon. Please be patient while we take a look. 🙌

O2sa commented Jun 23, 2026
edited
Loading

Copy link
Copy Markdown
Owner

Close the other PR and close the relative issue by adding this to the PR description:

Close #ISSUE_ID

And I will be happy to accept this PR.

Copy link
Copy Markdown
Contributor Author

You may merge this PR now as I have closed the earlier one and My apologies for all the inconvenience caused :)

O2sa commented Jun 24, 2026
edited
Loading

Copy link
Copy Markdown
Owner

Another time add the close command in the PR that's will be merged and the issue will be closed automatically, like how I did here: #167 (comment)

And don't forget to star the repo :)

@O2sa O2sa merged commit 2691db0 into O2sa:main Jun 24, 2026
2 of 3 checks passed
Repository owner deleted a comment from github-actions Bot Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@O2sa O2sa O2sa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: Make GitHub fetch counts configurable via env vars

AltStyle によって変換されたページ (->オリジナル) /