This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Commit cc55d4f

authored

fix(HMR): modulePath on Windows to apply changes in app styles at runtime (#807)

* fix(HMR): modulePath on Windows Replace backslashes with forward slashes. * refactor: rename a method

1 parent bf1cc33 commit cc55d4fCopy full SHA for cc55d4f

File tree

+15

-6

lines changed

+15

-6

lines changed

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,8 @@`
`1`	`1`	`const os = require("os");`
`2`		`-const path = require("path");`
`3`	`2`
`4`	`3`	`const {`
`5`	`4`	`getAppPathFromProjectData,`
`6`	`5`	`getAppResourcesPathFromProjectData,`
`7`		`- getProjectDir,`
`8`	`6`	`isAndroid,`
`9`	`7`	`} = require("../projectHelpers");`
`10`	`8`
`@@ -92,12 +90,17 @@ function removeListener(eventEmitter, name) {`
`92`	`90`	`}`
`93`	`91`	`}`
`94`	`92`
	`93`	`+function convertToUnixPath(relativePath) {`
	`94`	`+ return relativePath.replace(/\\/g, "/");`
	`95`	`+}`
	`96`	`+`
`95`	`97`	`module.exports = {`
`96`	`98`	`buildEnvData,`
`97`	`99`	`debuggingEnabled,`
`98`	`100`	`shouldSnapshot,`
`99`	`101`	`getUpdatedEmittedFiles,`
`100`	`102`	`parseHotUpdateChunkName,`
`101`	`103`	`addListener,`
`102`		`- removeListener`
	`104`	`+ removeListener,`
	`105`	`+ convertToUnixPath`
`103`	`106`	`};`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,9 @@`
`1`	`1`	`const { reload } = require("./hot-loader-helper");`
	`2`	`+const { convertToUnixPath } = require("./lib/utils");`
`2`	`3`
`3`	`4`	`module.exports = function (source) {`
`4`	`5`	`const typeMarkup = "markup";`
`5`		`- const modulePath = this.resourcePath.replace(this.rootContext, ".");`
	`6`	`+ const moduleRelativePath = this.resourcePath.replace(this.rootContext, ".");`
	`7`	`+ const modulePath = convertToUnixPath(moduleRelativePath);`
`6`	`8`	return `${source};${reload({ type: typeMarkup, path: modulePath })}`;
`7`	`9`	`};`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,9 @@`
`1`	`1`	`const { reload } = require("./hot-loader-helper");`
	`2`	`+const { convertToUnixPath } = require("./lib/utils");`
`2`	`3`
`3`	`4`	`module.exports = function (source) {`
`4`	`5`	`const typeScript = "script";`
`5`		`- const modulePath = this.resourcePath.replace(this.rootContext, ".");`
	`6`	`+ const moduleRelativePath = this.resourcePath.replace(this.rootContext, ".");`
	`7`	`+ const modulePath = convertToUnixPath(moduleRelativePath);`
`6`	`8`	return `${source};${reload({ type: typeScript, path: modulePath })}`;
`7`	`9`	`};`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,9 @@`
`1`	`1`	`const { reload } = require("./hot-loader-helper");`
	`2`	`+const { convertToUnixPath } = require("./lib/utils");`
`2`	`3`
`3`	`4`	`module.exports = function (source) {`
`4`	`5`	`const typeStyle = "style";`
`5`		`- const modulePath = this.resourcePath.replace(this.rootContext, ".");`
	`6`	`+ const moduleRelativePath = this.resourcePath.replace(this.rootContext, ".");`
	`7`	`+ const modulePath = convertToUnixPath(moduleRelativePath);`
`6`	`8`	return `${source};${reload({ type: typeStyle, path: modulePath })}`;
`7`	`9`	`};`

Comments

(0)