This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Commit b4800c8

rosen-vladimirovsis0k0

authored and

committed

fix(ns-bundle): support for Node.js 9 (#321)

When you have Node.js 9 installed, CLI prints a warning that support for this version is not verified. Our webpack plugin tries to get the version, but it receives the warning and decides the version is incorrect. So all scripts fail. In order to resolve the issue, get all data send to the stdout of the spawned `tns --version` process and parse it.

1 parent fc45d4f commit b4800c8Copy full SHA for b4800c8

File tree

1 file changed

+10

-5

lines changed

bin
- ns-bundle

1 file changed

+10

-5

lines changed

`‎bin/ns-bundle‎`

Lines changed: 10 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,8 @@ execute(options);`
`53`	`53`
`54`	`54`	`function execute(options) {`
`55`	`55`	`const platform = options.platform;`
`56`		`- let commands = [`
`57`		`- () => runTns("prepare", platform)`
	`56`	`+ let commands = [`
	`57`	`+ () => runTns("prepare", platform)`
`58`	`58`	`];`
`59`	`59`
`60`	`60`	`if (options.bundle) {`
`@@ -70,7 +70,7 @@ function execute(options) {`
`70`	`70`	`if (shouldSnapshot(platform, options.env)) {`
`71`	`71`	`commands.push(() => installSnapshotArtefacts());`
`72`	`72`	`}`
`73`		`-`
	`73`	`+`
`74`	`74`	`// If "build-app" or "start-app" is specified,`
`75`	`75`	`// the respective command should be run last.`
`76`	`76`	`if (options.command) {`
`@@ -123,15 +123,20 @@ function gradlewClean() {`
`123`	`123`	`function getTnsVersion() {`
`124`	`124`	`return new Promise((resolve, reject) => {`
`125`	`125`	`const childProcess = spawn("tns", ["--version"], { shell: true });`
`126`		`-`
`127`		`- childProcess.stdout.on("data", version => resolve(version.toString()));`
	`126`	`+letstdoutData="";`
	`127`	`+ childProcess.stdout.on("data", data => stdoutData+=data);`
`128`	`128`
`129`	`129`	`childProcess.on("close", code => {`
`130`	`130`	`if (code) {`
`131`	`131`	`reject({`
`132`	`132`	`code,`
`133`	`133`	message: `child process exited with code ${code}`,
`134`	`134`	`});`
	`135`	`+ } else {`
	`136`	`+ const versionRegex = /^(?:\d+\.){2}\d+.*?$/m;`
	`137`	`+ const matches = stdoutData.toString().match(versionRegex);`
	`138`	`+ const version = matches && matches[0] && matches[0].trim();`
	`139`	`+ resolve(version);`
`135`	`140`	`}`
`136`	`141`	`});`
`137`	`142`	`});`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit b4800c8

File tree

1 file changed

1 file changed

`‎bin/ns-bundle‎`

0 commit comments