This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Commit 874e4f8

authored

fix: hmr should work with uglify (#953)

Currently `hmr` with `--env.uglify` is not working as the uglifier touches all files. This leads to emit of files that are not hot updates. When CLI finds such files, it decides hmr is not successful and restarts the application. However, some of the emitted files are not actully changed. These emitted (and not changed) files are chunks of the entry points - as we are with HMR if there's an actual change for them, we'll receive hot-update files. Currently there's a logic to skip all emitted entry points and webpack runtime files (`runtime.js`) when we are with HMR. To fix the current issue, extend this logic to skip emitted chunks of entry points as well when we are with HMR and there's no hot-update for them.

1 parent 4bbf839 commit 874e4f8Copy full SHA for 874e4f8

File tree

1 file changed

-4

lines changed

plugins
- WatchStateLoggerPlugin.ts

1 file changed

-4

lines changed

`‎plugins/WatchStateLoggerPlugin.ts‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,10 +64,9 @@ function getWebpackRuntimeOnlyFiles(compilation) {`
`64`	`64`	`function getEntryPointFiles(compilation) {`
`65`	`65`	`const entryPointFiles = [];`
`66`	`66`	`try {`
`67`		`- Array.from(compilation.entrypoints.values())`
	`67`	`+ Array.from(compilation.entrypoints.values())`
`68`	`68`	`.forEach((entrypoint: any) => {`
`69`		`- const entryChunk = entrypoint.chunks.find(chunk => chunk.name === entrypoint.options.name);`
`70`		`- if (entryChunk) {`
	`69`	`+ for (const entryChunk of entrypoint.chunks) {`
`71`	`70`	`entryChunk.files.forEach(fileName => {`
`72`	`71`	`if (fileName.indexOf("hot-update") === -1) {`
`73`	`72`	`entryPointFiles.push(fileName);`
`@@ -79,5 +78,6 @@ function getEntryPointFiles(compilation) {`
`79`	`78`	`console.log("Warning: Unable to find Webpack entry point files.");`
`80`	`79`	`}`
`81`	`80`
`82`		`- return entryPointFiles;`
	`81`	`+ return entryPointFiles`
	`82`	`+ .filter((value, index, self) => self.indexOf(value) === index); // get only the unique files`
`83`	`83`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 874e4f8

File tree

1 file changed

1 file changed

`‎plugins/WatchStateLoggerPlugin.ts‎`

0 commit comments